Skip to content

Refactor PersonalCards BankConnection native loader to ActivityIndicator #96820

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Julesssss merged 4 commits into from
Aug 3, 2026
+2 −2
Merged

Refactor PersonalCards BankConnection native loader to ActivityIndicator #96820

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
abfea33
Refactor PersonalCards BankConnection native loader to ActivityIndicator
MelvinBot Jul 23, 2026
286cde0
Use shared LoadingIndicator component for BankConnection WebView loader
MelvinBot Aug 3, 2026
7e8cfe9
Drop redundant flex1 style and revert reason attributes name
MelvinBot Aug 3, 2026
ecbec3c
Fix: run oxfmt on BankConnection/index.native.tsx
MelvinBot Aug 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/pages/settings/Wallet/PersonalCards/steps/BankConnection/index.native.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import ActivityIndicator from '@components/ActivityIndicator';
import FullPageOfflineBlockingView from '@components/BlockingViews/FullPageOfflineBlockingView';
import FullScreenLoadingIndicator from '@components/FullscreenLoadingIndicator';
import HeaderWithBackButton from '@components/HeaderWithBackButton';
import LoadingIndicator from '@components/LoadingIndicator';
import ScreenWrapper from '@components/ScreenWrapper';

import useImportPersonalPlaidAccounts from '@hooks/useImportPersonalPlaidAccounts';
Expand Down Expand Up @@ -55,7 +55,7 @@ function BankConnection() {
isNewCardError,
};

const renderLoading = () => <FullScreenLoadingIndicator reasonAttributes={fullscreenReasonAttributes} />;
const renderLoading = () => <LoadingIndicator reasonAttributes={fullscreenReasonAttributes} />;

const handleBackButtonPress = () => {
setAddNewPersonalCardStepAndData({step: CONST.PERSONAL_CARDS.STEP.SELECT_BANK});
Expand Down
Loading