Skip to content

[HOLD - TESTING][Typography] Add semantic type tokens and block new raw font sizes - #96880

Draft
grgia wants to merge 11 commits into
mainfrom
georgia-font-lib
Draft

[HOLD - TESTING][Typography] Add semantic type tokens and block new raw font sizes#96880
grgia wants to merge 11 commits into
mainfrom
georgia-font-lib

Conversation

@grgia

@grgia grgia commented Jul 23, 2026

Copy link
Copy Markdown
Contributor

Explanation of Change

Text styles now come from a typography token layer (src/styles/typography.ts), and new raw fontSize/lineHeight literals are blocked by lint.

Type styles have drifted with nothing to stop it: fontSizeH1 and fontSizeH2 are both 19, and ~75 text* styles express about a dozen real roles because color is baked into type styles. The token file defines a primitive scale plus semantic variants named after the Figma type styles, and the existing text* styles are aliased to those tokens with color re-attached at the alias boundary. Design confirmed the Figma library is the source of truth for values, so this PR also aligns four drifted values (headline line height 32→28, label 18→16, micro strong 16→14, intro headline 45→44). Everything else renders exactly as before.

  • Variants named 1:1 after the Figma Product/* styles
  • <Text variant="..."> added, fontSize prop deprecated
  • Existing violations grandfathered via eslint-seatbelt
  • QRShare migrated as the worked example
  • Headline, label, micro strong, intro headline line heights aligned to Figma
  • introHeadline matches the new Figma Product/Intro Headline style
  • Other call-sites heal as edited
  • Unit tests cover the lint rule and variant prop

Fixed Issues

$ #37503
PROPOSAL:

Tests

  1. Run npm run test -- tests/unit/NoRawTypographyRuleTest.ts tests/unit/TextVariantTest.tsx and verify both suites pass.
  2. Add fontSize: 17 to any component style, run npm run lint on that file, and verify the rulesdir/no-raw-typography error appears.
  3. Open any chat, verify headings, message text, labels, and timestamps render identically to main.
  4. Go to Settings > Share code and verify the title and subtitle spacing.
  5. Open a workspace overview page and verify section titles and form labels look right (slightly tighter line heights than production, per design).
  6. Open a brand-new chat and verify the large welcome headline renders correctly.
  • Verify that no errors appear in the JS console

Offline tests

None, style definitions only. No network-dependent behavior.

QA Steps

  1. Open any chat and a Settings page.
  2. Verify headings, section titles, and labels render slightly tighter than production (headline 28px, label 16px line heights) with no clipping or overlap.
  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari

@github-actions

Copy link
Copy Markdown
Contributor

🚧 grgia has triggered a test Expensify/App build. You can view the workflow run here.

@github-actions

This comment has been minimized.

@github-actions

Copy link
Copy Markdown
Contributor

🚧 grgia has triggered a test Expensify/App build. You can view the workflow run here.

@github-actions

This comment has been minimized.

Comment on lines 108 to +109
<Text
fontSize={variables.fontSizeLabel}
variant="label"

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Example

@github-actions

Copy link
Copy Markdown
Contributor

🚧 grgia has triggered a test Expensify/App build. You can view the workflow run here.

@github-actions

Copy link
Copy Markdown
Contributor

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #96880.

Android 🤖 iOS 🍎
⏩ SKIPPED ⏩ ⏩ SKIPPED ⏩
The build for Android was skipped The build for iOS was skipped
Web 🕸️
https://96880.pr-testing.expensify.com
Web

👀 View the workflow run that generated this build 👀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant