Skip to content

Fix: use a unique filename for iOS shared images to fix stale receipt preview #97038

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
MelvinBot wants to merge 1 commit into
base: main
Choose a base branch
from
+4 −1
Draft

Fix: use a unique filename for iOS shared images to fix stale receipt preview #97038

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion ios/ShareViewController/ShareViewController.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -192,7 +192,10 @@ class ShareViewController: UIViewController {

private func handleImageData(_ image: UIImage, folder: URL, completion: @escaping (FileSaveError?) -> Void) {
os_log("Handling image data")
let filename = "shared_image.png"
// Use a unique filename per share so the resulting file:// URI differs every time.
// A constant name produced an identical URI on every share, and the URI-keyed image
// cache kept serving the first decoded receipt. See https://github.com/Expensify/App/issues/95075
let filename = "shared_image_\(UUID().uuidString).png"
processAndSave(data: image.pngData(), filename: filename, folder: folder, completion: completion)
}

Expand Down
Loading