-
Notifications
You must be signed in to change notification settings - Fork 4k
[Insights: Violations]: Expanding group & Suggested search #97067
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
nkdengineer
wants to merge
17
commits into
Expensify:main
Choose a base branch
from
nkdengineer:fix/95859
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
323bd5d
feat: Expanding group & Suggested search
nkdengineer 3643b73
fix test
nkdengineer d43b90f
add unit test
nkdengineer c2e370b
resolve conflict
nkdengineer 1eb0ffb
update translation for violation name
nkdengineer 4d4cea4
refactor code
nkdengineer 3666837
update unit test
nkdengineer 7f502aa
remove disable eslint
nkdengineer 9617712
resolve conflict
nkdengineer 3486114
move translation to existing ke
nkdengineer aed2dfa
fix test
nkdengineer bdee2a0
resolve conflict
nkdengineer df261bc
update non sortable list
nkdengineer fc4f39e
Merge branch 'main' into fix/95859
nkdengineer 76a0ca9
Merge branch 'main' into fix/95859
nkdengineer 2f31cf6
only display violation column when data is available and remove it fr…
nkdengineer e85a444
resolve conflict
nkdengineer File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -333,6 +333,7 @@ const translations: TranslationDeepObject<typeof en> = { | |
| billable: 'Abrechenbar', | ||
| nonBillable: 'Nicht abrechenbar', | ||
| tag: 'Tag', | ||
| violations: 'Violations', | ||
| receipt: 'Beleg', | ||
| verified: 'Verifiziert', | ||
| replace: 'Ersetzen', | ||
|
|
@@ -9168,6 +9169,7 @@ Fügen Sie weitere Ausgabelimits hinzu, um den Cashflow Ihres Unternehmens zu sc | |
| topSpenders: 'Höchste Ausgaben', | ||
| topCategories: 'Topkategorien', | ||
| topMerchants: 'Top-Händler', | ||
| violationsBySubmitter: 'Violations by submitter', | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Untranslated copy |
||
| }, | ||
| }, | ||
| genericErrorPage: { | ||
|
|
@@ -9833,7 +9835,52 @@ Fügen Sie weitere Ausgabelimits hinzu, um den Cashflow Ihres Unternehmens zu sc | |
| customUnitRateOutOfDateRangeStartOnly: ({startDate}: {startDate: string}) => `Der Satz gilt erst ab dem ${startDate}`, | ||
| customUnitRateOutOfDateRangeEndOnly: ({endDate}: {endDate: string}) => `Satz gilt nur bis ${endDate}`, | ||
| cannotMergeDuplicates: 'Sie können Ausgaben nur in Entwürfen oder offenen Berichten zusammenführen. Ziehen Sie den Bericht zurück und versuchen Sie es erneut.', | ||
| shortName: { | ||
| allTagLevelsRequired: 'All tags required', | ||
| autoReportedRejectedExpense: 'Expense rejected', | ||
| billableExpense: 'Billable no longer valid', | ||
| cashExpenseWithNoReceipt: 'Receipt required', | ||
| categoryOutOfPolicy: 'Category no longer valid', | ||
| companyCardRequired: 'Company card required', | ||
| conversionSurcharge: 'Conversion surcharge applied', | ||
| customUnitOutOfPolicy: 'Rate not valid for workspace', | ||
| customUnitRateOutOfDateRange: 'Rate outside valid dates', | ||
| duplicatedTransaction: 'Potential duplicate', | ||
| fieldRequired: 'Report field required', | ||
| futureDate: 'Future date not allowed', | ||
| hold: 'Expense on hold', | ||
| inactiveVendor: 'Vendor no longer valid', | ||
| increasedDistance: 'Distance exceeds route', | ||
| invoiceMarkup: 'Invoice marked up', | ||
| itemizedReceiptRequired: 'Itemized receipt required', | ||
| maxAge: 'Expense too old', | ||
| missingAttendees: 'Attendees required', | ||
| missingCategory: 'Missing category', | ||
| missingComment: 'Description required', | ||
| missingTag: 'Missing tag', | ||
| modifiedAmount: 'Amount modified', | ||
| modifiedDate: 'Date modified', | ||
| noRoute: 'No valid route', | ||
| nonExpensiworksExpense: 'Non-Expensiworks expense', | ||
| overAutoApprovalLimit: 'Over auto-approval limit', | ||
| overCategoryLimit: 'Over category limit', | ||
| overLimit: 'Over limit', | ||
| overTripLimit: 'Over trip limit', | ||
| perDayLimit: 'Over daily limit', | ||
| prohibitedExpense: 'Prohibited expense', | ||
| receiptGeneratedWithAI: 'Possible AI-generated receipt', | ||
| receiptNotSmartScanned: 'Receipt added manually', | ||
| receiptRequired: 'Receipt required', | ||
| rter: 'Awaiting card match', | ||
| smartscanFailed: 'Receipt scanning failed', | ||
| someTagLevelsRequired: 'Tag required', | ||
| taxAmountChanged: 'Tax amount modified', | ||
| taxOutOfPolicy: 'Tax rate no longer valid', | ||
| taxRateChanged: 'Tax rate modified', | ||
| taxRequired: 'Missing tax rate', | ||
| }, | ||
| }, | ||
|
|
||
| reportViolations: { | ||
| [CONST.REPORT_VIOLATIONS.FIELD_REQUIRED]: (fieldName: string) => `${fieldName} ist erforderlich`, | ||
| reportContainsExpensesWithViolations: 'Der Bericht enthält Ausgaben mit Verstößen.', | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this behavior expected according to the design? Since this is a string, I think we should enable sorting for consistency with other columns
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's ok to do that in a follow up. The backend doesn't support sorting by it yet.