Show a processing empty state while a CSV company card import is still running - #97078
Closed
allgandalf wants to merge 13 commits into
Closed
Show a processing empty state while a CSV company card import is still running#97078allgandalf wants to merge 13 commits into
allgandalf wants to merge 13 commits into
Conversation
|
Hey, I noticed you changed If you want to automatically generate translations for other locales, an Expensify employee will have to:
Alternatively, if you are an external contributor, you can run the translation script locally with your own OpenAI API key. To learn more, try running: npx ts-node ./scripts/generateTranslations.ts --helpTypically, you'd want to translate only what you changed by running |
…state # Conflicts: # src/components/Tables/WorkspaceCompanyCardsTable/index.tsx
Contributor
Author
|
closing in favour of App #97175, which does the same importing state frontend only and is further along. left the design illustration and copy from 88496 as a comment over there |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
CSV imports are async, the uploaded file takes ~90s to reach the scrapers, so until then the feed read returns nothing and the table says
No cards in this feedwhile the import is still running. Auth now stampsimportStartedAton the feed (Auth #23237) and this swaps the empty state copy and illustration while that stamp is set and the feed has no cards.Gating on the card list being empty means it clears as soon as cards land, and Auth drops the marker at that same point. No timers and no fixed window on the client. A CSV that parses to zero cards keeps showing the state, there is no completion signal to clear it on yet.
cc @Expensify/design, copy and illustration are from Jon's mocks.
Fixed Issues
$ #88496
PROPOSAL: #88496 (comment)
Tests
Cards will appear in a moment...with the card reconciliation illustration, notNo cards in this feedNo cards in this feedOffline tests
The import itself needs a connection. Once the stamp is in Onyx the empty state is derived locally, so it keeps showing while offline until a feed read clears the stamp.
QA Steps
Same as tests.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari