Skip to content

[Search Router] Add Create actions to navigation suggestions - #97086

Open
nabi-ebrahimi wants to merge 13 commits into
Expensify:mainfrom
nabi-ebrahimi:92752-search-router-create-actions
Open

[Search Router] Add Create actions to navigation suggestions#97086
nabi-ebrahimi wants to merge 13 commits into
Expensify:mainfrom
nabi-ebrahimi:92752-search-router-create-actions

Conversation

@nabi-ebrahimi

@nabi-ebrahimi nabi-ebrahimi commented Jul 27, 2026

Copy link
Copy Markdown
Contributor

Explanation of Change

Adds Create/FAB actions to Search Router navigation suggestions:

  • Create expense
  • Create report
  • Track distance
  • New chat
  • Send invoice
  • New workspace

The suggestions reuse the existing FAB actions, icons, visibility rules, saved distance type, and Create Report branching logic. Search Router closes before executing an action, and an existing RHP is dismissed before opening the new flow to prevent modal stacking.

Navigation matching now ignores repeated whitespace, so queries such as go to create expense match correctly.

Quick Action and Book Travel are intentionally excluded from this focused PR.

Fixed Issues

$ #92752
PROPOSAL: #92752 (comment)

Tests

Create action matching

  1. Sign in and open Search Router.
  2. Search for create expense.
  3. Repeat with expense, go to create expense, go to create expense, and CREATE EXPENSE.
  4. Verify Create expense appears with the correct icon and without a Go to prefix.

Create expense

  1. Search for create expense.
  2. Select the result.
  3. Verify Search Router closes and the normal Create expense flow opens.

Track distance

  1. Open Track distance from the FAB and select a distance type such as Map or Odometer.
  2. Close the flow.
  3. Open Search Router and select Track distance.
  4. Verify the distance flow opens using the previously selected distance type.

Create report

  1. Search for create report and select it.
  2. Test with an account that has one eligible workspace.
  3. Test with an account that has multiple eligible workspaces.
  4. Verify the existing report confirmation, workspace selection, or report creation flow opens as appropriate, matching the FAB behavior.

New chat

  1. Search for new chat.
  2. Select the result.
  3. Verify Search Router closes and the normal new-chat flow opens.

Send invoice visibility

  1. Use an account with an invoice-enabled admin workspace.
  2. Search for invoice.
  3. Verify Send invoice appears and opens the invoice flow.
  4. Repeat with an account without invoice permission.
  5. Verify the navigation suggestion is not shown.

New workspace visibility

  1. Use an account without a visible workspace.
  2. Search for new workspace.
  3. Verify the suggestion appears and opens workspace creation.
  4. Repeat with an account where the FAB does not show New workspace.
  5. Verify Search Router also hides the suggestion.

Existing RHP replacement

  1. Open an Account or Workspace RHP.
  2. Open Search Router while the RHP is open.
  3. Select an available Create action.
  4. Verify the previous RHP closes before the Create flow opens.
  5. Verify the modals do not stack and one Back action closes the Create flow.

Keyboard navigation

  1. Search for a Create action.
  2. Select it using the arrow keys and Enter.
  3. Repeat using a mouse or tap.
  4. Verify both methods open the same flow.

Excluded actions

  1. Search for quick action.
  2. Search for book travel.
  3. Verify no Create navigation suggestion appears for either action.

Existing Search Router regression

  1. Search for inbox and select Go to Inbox.
  2. Run a normal text search.
  3. Use Ask Concierge.
  4. Verify existing navigation, regular search, and Concierge flows continue working.
  • Verify that no errors appear in the JS console

Offline tests

Same as Tests.

QA Steps

Same as Tests.

// TODO: These must be filled out, or the issue title must include "[No QA]."

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Screen_Recording_20260728_165639_New.Expensify.Dev.mp4
Android: mWeb Chrome
Screen_Recording_20260728_170356_Chrome.mp4
iOS: Native
Screen.Recording.2026-07-28.at.5.33.00.PM.mov
iOS: mWeb Safari
Screen.Recording.2026-07-28.at.5.08.49.PM.mov
MacOS: Chrome / Safari
Screen.Recording.2026-07-28.at.8.34.14.AM.mov
Screen.Recording.2026-07-28.at.8.36.34.AM.mov
Screen.Recording.2026-07-28.at.8.38.11.AM.mov
Screen.Recording.2026-07-28.at.8.42.11.AM.mov
Screen.Recording.2026-07-28.at.8.47.37.AM.mov
Screen.Recording.2026-07-28.at.8.53.29.AM.mov
Screen.Recording.2026-07-28.at.9.00.16.AM.mov
Screen.Recording.2026-07-28.at.9.11.08.AM.mov

@codecov

codecov Bot commented Jul 27, 2026

Copy link
Copy Markdown

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines Coverage Δ
...ponents/Search/SearchRouter/SearchRouterHelpers.ts 95.55% <100.00%> (+0.10%) ⬆️
...s/Search/SearchRouter/useNavigationSuggestions.tsx 100.00% <100.00%> (ø)
...rch/SearchRouter/useCreateNavigationSuggestions.ts 98.00% <98.00%> (ø)
... and 33 files with indirect coverage changes

@nabi-ebrahimi
nabi-ebrahimi marked this pull request as ready for review July 30, 2026 12:27
@nabi-ebrahimi
nabi-ebrahimi requested review from a team as code owners July 30, 2026 12:27
@melvin-bot
melvin-bot Bot requested review from marufsharifi and removed request for a team July 30, 2026 12:27
@melvin-bot

melvin-bot Bot commented Jul 30, 2026

Copy link
Copy Markdown

@marufsharifi Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot
melvin-bot Bot requested review from heyjennahay and removed request for a team July 30, 2026 12:27
Comment thread src/components/Search/SearchRouter/useCreateNavigationSuggestions.ts Outdated

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 3ad46601fe

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment thread src/components/Search/SearchRouter/useCreateNavigationSuggestions.ts Outdated
@nabi-ebrahimi

nabi-ebrahimi commented Jul 31, 2026

Copy link
Copy Markdown
Contributor Author

@marufsharifi, Addressed the comments.

Comment thread tests/unit/SearchRouterNavigationTest.ts
@nabi-ebrahimi

Copy link
Copy Markdown
Contributor Author

@marufsharifi all review comments have been addressed, including the dedicated Create navigation hook coverage. Thanks for the thorough review!

@marufsharifi

Copy link
Copy Markdown
Contributor

Reviewer Checklist

  • I have verified the author checklist is complete (all boxes are checked off).
  • I verified the correct issue is linked in the ### Fixed Issues section above
  • I verified testing steps are clear and they cover the changes made in this PR
    • I verified the steps for local testing are in the Tests section
    • I verified the steps for Staging and/or Production testing are in the QA steps section
    • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I checked that screenshots or videos are included for tests on all platforms
  • I included screenshots or videos for tests on all platforms
  • I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
  • I verified tests pass on all platforms & I tested again on:
    • Android: HybridApp
    • Android: mWeb Chrome
    • iOS: HybridApp
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
  • I verified proper code patterns were followed (see Reviewing the code)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I verified that this PR follows the guidelines as stated in the Review Guidelines
  • I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
  • If a new component is created I verified that:
    • A similar component doesn't exist in the codebase
    • All props are defined accurately
    • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
    • The only data being stored in the state is data necessary for rendering and nothing else
    • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
  • I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp
Android: mWeb Chrome
iOS: HybridApp
iOS: mWeb Safari
MacOS: Chrome / Safari

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants