[Search Router] Add Create actions to navigation suggestions - #97086
[Search Router] Add Create actions to navigation suggestions#97086nabi-ebrahimi wants to merge 13 commits into
Conversation
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
|
@marufsharifi Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 3ad46601fe
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
|
@marufsharifi, Addressed the comments. |
|
@marufsharifi all review comments have been addressed, including the dedicated Create navigation hook coverage. Thanks for the thorough review! |
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppAndroid: mWeb ChromeiOS: HybridAppiOS: mWeb SafariMacOS: Chrome / Safari |
Explanation of Change
Adds Create/FAB actions to Search Router navigation suggestions:
The suggestions reuse the existing FAB actions, icons, visibility rules, saved distance type, and Create Report branching logic. Search Router closes before executing an action, and an existing RHP is dismissed before opening the new flow to prevent modal stacking.
Navigation matching now ignores repeated whitespace, so queries such as
go to create expensematch correctly.Quick Action and Book Travel are intentionally excluded from this focused PR.
Fixed Issues
$ #92752
PROPOSAL: #92752 (comment)
Tests
Create action matching
create expense.expense,go to create expense,go to create expense, andCREATE EXPENSE.Create expenseappears with the correct icon and without aGo toprefix.Create expense
create expense.Track distance
Track distance.Create report
create reportand select it.New chat
new chat.Send invoice visibility
invoice.Send invoiceappears and opens the invoice flow.New workspace visibility
new workspace.Existing RHP replacement
Keyboard navigation
Excluded actions
quick action.book travel.Existing Search Router regression
inboxand selectGo to Inbox.Offline tests
Same as Tests.
QA Steps
Same as Tests.
// TODO: These must be filled out, or the issue title must include "[No QA]."
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Screen_Recording_20260728_165639_New.Expensify.Dev.mp4
Android: mWeb Chrome
Screen_Recording_20260728_170356_Chrome.mp4
iOS: Native
Screen.Recording.2026-07-28.at.5.33.00.PM.mov
iOS: mWeb Safari
Screen.Recording.2026-07-28.at.5.08.49.PM.mov
MacOS: Chrome / Safari
Screen.Recording.2026-07-28.at.8.34.14.AM.mov
Screen.Recording.2026-07-28.at.8.36.34.AM.mov
Screen.Recording.2026-07-28.at.8.38.11.AM.mov
Screen.Recording.2026-07-28.at.8.42.11.AM.mov
Screen.Recording.2026-07-28.at.8.47.37.AM.mov
Screen.Recording.2026-07-28.at.8.53.29.AM.mov
Screen.Recording.2026-07-28.at.9.00.16.AM.mov
Screen.Recording.2026-07-28.at.9.11.08.AM.mov