Skip to content

Add tag GL code display in tag picker - #97094

Open
neerajbachani wants to merge 2 commits into
Expensify:mainfrom
neerajbachani:96390-show-tag-gl-codes-in-picker
Open

Add tag GL code display in tag picker#97094
neerajbachani wants to merge 2 commits into
Expensify:mainfrom
neerajbachani:96390-show-tag-gl-codes-in-picker

Conversation

@neerajbachani

@neerajbachani neerajbachani commented Jul 27, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Explanation of Change

This PR adds the ability for admins to display tag GL codes when selecting a tag in the tag picker

Changes include:

  • Added showTagGLCodes policy flag and SetPolicyShowTagGLCodes API action with optimistic update / failure rollback
  • Added getGLCodeFromPolicyTag and getPolicyTagGLCode helpers in PolicyUtils.ts
  • Updated TagsOptionsListUtils to render GL codes as alternateText (muted second line) and include GL codes in tokenizedSearch
  • Updated TagPicker to read !!policy?.showTagGLCodes && !!policy?.glCodes and pass shouldShowGLCode down
  • Added "Show GL codes when selecting a tag" toggle in WorkspaceTagsSettingsPage, gated on policy.glCodes
  • Added unit tests in PolicyTagTest, PolicyUtilsTest, and TagsOptionsListUtilsTest

Backend dependency: This PR requires a backend SetPolicyShowTagGLCodes command (same pattern as category GL codes). Until the backend is deployed, toggling the setting on will optimistically show GL codes briefly, then roll back with an error when the API call fails.

Fixed Issues

$ #96390
PROPOSAL: #96390 (comment)

Tests

  1. Open a workspace that has GL codes enabled and tags with GL codes configured (e.g. a project tag like "Sunshine Project" with GL code "SP4100")
  2. Go to Workspace > Tags > Settings
  3. Verify the Show GL codes when selecting a tag toggle is visible (only when policy.glCodes is enabled)
  4. Turn the toggle ON (note: will roll back with error until backend SetPolicyShowTagGLCodes is deployed; GL codes still appear optimistically for a few seconds)
  5. Create or edit an expense and open the tag picker
  6. Verify each tag shows its GL code as a muted second line below the tag name (e.g. "Sunshine Project" / "SP4100")
  7. Search for a GL code (e.g. "SP4100") and verify matching tags appear
  8. Select a tag and confirm the expense saves with the correct tag name
  9. Turn the toggle OFF and verify GL codes no longer appear in the tag picker
  10. Verify tag picker behavior is unchanged when the toggle is off or when the workspace has no GL codes enabled
  • Verify that no errors appear in the JS console

Offline tests

  1. Go offline
  2. Toggle Show GL codes when selecting a tag ON in workspace tag settings
  3. Verify the toggle updates optimistically while offline
  4. Open the tag picker and verify GL codes display from local policy data
  5. Go back online and verify the pending state clears (or shows error if backend endpoint is not yet deployed)

QA Steps

  1. Log in as a workspace admin on a Control workspace with GL codes and tags configured
  2. Navigate to Workspace > Tags > Settings
  3. Confirm Show GL codes when selecting a tag toggle appears when GL codes are enabled for the workspace
  4. Enable the toggle and create/edit an expense
  5. Open the tag picker and confirm GL codes appear as a second muted line under each tag name
  6. Search by GL code and confirm matching tags are returned
  7. Select a tag and confirm the expense is tagged correctly
  8. Disable the toggle and confirm GL codes no longer appear in the picker
  9. Verify no regressions in tag selection for workspaces without GL codes or with the toggle disabled
  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
Screen.Recording.2026-07-27.at.6.21.04.PM.mov

@neerajbachani
Add tag GL code display in tag picker
ec4795b 
Mirror the category GL code pattern with a showTagGLCodes policy toggle,
picker alternateText rendering, GL code search, and SetPolicyShowTagGLCodes API action.
@neerajbachani
neerajbachani requested review from a team as code owners July 27, 2026 12:23
@melvin-bot

melvin-bot Bot commented Jul 27, 2026

Copy link
Copy Markdown

Hey, I noticed you changed src/languages/en.ts in a PR from a fork. For security reasons, translations are not generated automatically for PRs from forks.

If you want to automatically generate translations for other locales, an Expensify employee will have to:

  1. Look at the code and make sure there are no malicious changes.
  2. Run the Generate static translations GitHub workflow. If you have write access and the K2 extension, you can simply click: [this button]

Alternatively, if you are an external contributor, you can run the translation script locally with your own OpenAI API key. To learn more, try running:

npx ts-node ./scripts/generateTranslations.ts --help

Typically, you'd want to translate only what you changed by running npx ts-node ./scripts/generateTranslations.ts --compare-ref main

@melvin-bot
melvin-bot Bot requested review from DylanDylann and heyjennahay July 27, 2026 12:24
@melvin-bot

melvin-bot Bot commented Jul 27, 2026

Copy link
Copy Markdown

@DylanDylann Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot
melvin-bot Bot removed request for a team July 27, 2026 12:24
chatgpt-codex-connector[bot]
chatgpt-codex-connector Bot reviewed Jul 27, 2026
View reviewed changes

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: ec4795bbb8

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment thread src/libs/actions/Policy/Tag.ts Outdated
github-actions[bot]
github-actions Bot reviewed Jul 27, 2026
View reviewed changes
Comment thread src/libs/PolicyUtils.ts Outdated
github-actions[bot]
github-actions Bot reviewed Jul 27, 2026
View reviewed changes
Comment thread src/pages/workspace/tags/WorkspaceTagsSettingsPage.tsx Outdated
@neerajbachani
Fix tag GL code rollback and add locale translations
5858062 
Capture prior showTagGLCodes value on API failure, dedupe GL code
stripping in PolicyUtils, remove redundant useCallback, and add
workspace.tags.showTagGLCodes to all locale files.
@codecov

codecov Bot commented Jul 27, 2026 •
edited by github-actions Bot
Loading

Copy link
Copy Markdown

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines Coverage Δ
src/libs/API/types.ts 100.00% <ø> (ø)
src/libs/PolicyUtils.ts 77.47% <100.00%> (+0.15%) ⬆️
src/libs/TagsOptionsListUtils.ts 59.70% <94.44%> (+3.24%) ⬆️
src/libs/actions/Policy/Tag.ts 69.56% <83.33%> (+0.28%) ⬆️
src/components/TagPicker/index.tsx 1.72% <0.00%> (-0.07%) ⬇️
...pages/workspace/tags/WorkspaceTagsSettingsPage.tsx 0.00% <0.00%> (ø)
... and 27 files with indirect coverage changes

@neerajbachani

neerajbachani commented Jul 27, 2026

Copy link
Copy Markdown
Contributor Author

@DylanDylann we need a backend change - SetPolicyShowTagGLCodes command (same pattern as category GL codes). Until the backend is deployed, toggling the setting on will optimistically show GL codes briefly, then roll back with an error when the API call fails.

@DylanDylann

DylanDylann commented Jul 28, 2026

Copy link
Copy Markdown
Contributor

@blimpich Could you handle the required backend changes? ☝️

@flaviadefaria
flaviadefaria requested review from flaviadefaria and removed request for heyjennahay July 28, 2026 16:36
@blimpich

blimpich commented Jul 28, 2026

Copy link
Copy Markdown
Contributor

Sure, but for future reference this should've been handled probably from the beginning if we knew this was gonna need backend work. @flaviadefaria I would've asked a backend contributor to do the necessary work before tagging this external, or even just having the backend contributor complete the entire feature. That way one person implements it end-to-end rather than having to get multiple people to have to work on this.

@blimpich

blimpich commented Jul 29, 2026

Copy link
Copy Markdown
Contributor

Backend PRs are in review. Should be merged and deployed probably by Friday?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments
@chatgpt-codex-connector chatgpt-codex-connector[bot] chatgpt-codex-connector[bot] left review comments
@DylanDylann DylanDylann Awaiting requested review from DylanDylann
@flaviadefaria flaviadefaria Awaiting requested review from flaviadefaria

At least 1 approving review is required to merge this pull request.

Assignees

@neerajbachani neerajbachani

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@neerajbachani @DylanDylann @blimpich