Skip to content

[Phase 2 of #66427, sub-pr 4/5] Migrate deprecatedGetReportName → getReportName in pages + tests files - #97111

Draft
hoangzinh wants to merge 1 commit into
Expensify:mainfrom
hoangzinh:refactor/66427-phase2-sub4-pages-tests
Draft

[Phase 2 of #66427, sub-pr 4/5] Migrate deprecatedGetReportName → getReportName in pages + tests files#97111
hoangzinh wants to merge 1 commit into
Expensify:mainfrom
hoangzinh:refactor/66427-phase2-sub4-pages-tests

Conversation

@hoangzinh

@hoangzinh hoangzinh commented Jul 27, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Explanation of Change

Part of #66427. Phase 2, Sub-PR 4 of 5 Sub-PR 4 — migrate deprecatedGetReportName → getReportName per directory src/pages/** + tests.

Next step:

  • Final Sub-PR 5 — delete deprecatedGetReportName; the compiler proves zero callers remain and its baseline rows go to zero.

Fixed Issues

$ #66427
PROPOSAL: #66427 (comment)

Tests

  • Verify that no errors appear in the JS console

Offline tests

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."

1. Chat header - all report types

  1. Open a 1:1 DM, a group chat, a workspace room (#room), and a workspace expense chat.
  2. Verify each header shows the correct name for its type.
  3. Rename one of them from another tab.
  4. Verify the header updates without refresh.

2. Browser tab title

  1. Open a chat and look at the browser tab title.
  2. Open an expense report from Reports or Search.
  3. Verify the tab title matches the report currently open.
  4. Switch to another report, then rename the current report.
  5. Verify the tab title follows both times.

3. Report details - title and subtitle

  1. Open a chat, then a report, then a thread. For each, open the header > Details.
  2. Verify the title is the name of the report being viewed.
  3. For the thread, verify the title is the thread content and the small subtitle is the parent report/workspace name.

4. Room members

  1. Open a room > Details > Members.
  2. Verify the subtitle under the title is the report name.

5. Invite to room

  1. Open a room > Details > Members > Invite.
  2. Verify the header subtitle is the room name.
  3. Type the email of someone who is already a member.
  4. Verify the error message contains the correct room name (e.g. "X is already a member of (#room)").

6. Share code / QR

  1. Open a report > Details > Share code.
  2. Verify the text under the QR code is the report/room name.
  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Recording.2026-07-27.233205.mp4

@hoangzinh hoangzinh changed the title refactor(pages): use derived report name hook [Phase 4 of #66427, sub-pr 4/5] Migrate deprecatedGetReportName → getReportName in pages + tests files Jul 27, 2026
@hoangzinh hoangzinh changed the title [Phase 4 of #66427, sub-pr 4/5] Migrate deprecatedGetReportName → getReportName in pages + tests files [Phase 2 of #66427, sub-pr 4/5] Migrate deprecatedGetReportName → getReportName in pages + tests files Jul 27, 2026
@codecov

codecov Bot commented Jul 27, 2026 •
edited by github-actions Bot
Loading

Copy link
Copy Markdown

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines Coverage Δ
src/pages/DynamicReportDetailsPage.tsx 58.31% <100.00%> (ø)
src/pages/ShareCodePage.tsx 81.08% <100.00%> (ø)
src/pages/inbox/HeaderView.tsx 96.96% <100.00%> (ø)
src/pages/inbox/ReportHeader.tsx 70.27% <100.00%> (-0.79%) ⬇️
...report/ContextMenu/BaseReportActionContextMenu.tsx 86.14% <100.00%> (+0.08%) ⬆️
src/pages/workspace/rooms/WorkspaceRoomsPage.tsx 0.00% <ø> (ø)
...ABPopoverContent/menuItems/QuickActionMenuItem.tsx 64.21% <75.00%> (ø)
src/pages/DynamicEditReportFieldPage.tsx 0.00% <0.00%> (ø)
src/pages/DynamicReportParticipantsPage.tsx 0.00% <0.00%> (ø)
src/pages/DynamicRoomInvitePage.tsx 0.00% <0.00%> (ø)
... and 6 more
... and 192 files with indirect coverage changes

@hoangzinh
refactor(pages): replace deprecatedGetReportName
7837fcf 
Migrate pages and tests off deprecatedGetReportName to getReportName
with the useDerivedReportNameByReportID hook.

- Swap deprecatedGetReportName(report, reportAttributes) for
  getReportName(report, derivedName) across 16 page components
- Drop local reportByIDsSelector/useOnyx REPORT_ATTRIBUTES wiring in
  favor of useDerivedReportNameByReportID
- Pass reportAttributes?.[reportID]?.reportName directly in
  WorkspaceRoomsPage
- Update ReportNameUtilsTest to the new signature

Part of Expensify#66427 phase 2
@hoangzinh
hoangzinh force-pushed the refactor/66427-phase2-sub4-pages-tests branch from 77387bd to 7837fcf Compare July 27, 2026 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@hoangzinh hoangzinh

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@hoangzinh