Preserve Search context when deleting tasks - #97192
Draft
marufsharifi wants to merge 4 commits into
Draft
Conversation
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
When a task is deleted from
Spend > Chats/Search, the app should return to the same Search-owned route instead of navigating to an Inbox-owned report route. This change uses the task details route’s existing backTo value before deleting the task, so the user stays in the Search context while preserving the existing fallback behavior for non-Search task deletes.Fixed Issues
$ #85560
PROPOSAL: #85560 (comment)
Tests
Offline tests
QA Steps
// TODO: These must be filled out, or the issue title must include "[No QA]."
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Screen.Recording.2026-07-29.at.9.21.56.AM.mov
Android: mWeb Chrome
Screen_Recording_20260729_093325_Chrome.mp4
iOS: Native
Screen.Recording.2026-07-29.at.9.54.14.AM.mov
iOS: mWeb Safari
Screen.Recording.2026-07-29.at.9.56.37.AM.mov
MacOS: Chrome / Safari
Screen.Recording.2026-07-29.at.9.10.52.AM.mov