[CP staging] Revert "Navigate to the clicked expense in a multi-expense report preview- #92546" by MonilBhavsar · Pull Request #97198 · Expensify/App

MonilBhavsar · 2026-07-28T07:06:52Z

This reverts commit fd93ec9, reversing changes made to 8a12457.

Explanation of Change

Fixed Issues

$ #97184
$ #97183
$ #97158
$ #97149
PROPOSAL:

Tests

Verify that no errors appear in the JS console

Offline tests

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

…pense-preview-per-item-nav" This reverts commit fd93ec9, reversing changes made to 8a12457.

codecov · 2026-07-28T07:10:45Z

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines	Coverage Δ
...RequestReportPreview/ReportPreviewActionButton.tsx	`100.00% <100.00%> (ø)`
...portActionItem/MoneyRequestReportPreview/index.tsx	`92.30% <100.00%> (-0.68%)`	⬇️
src/libs/Navigation/Navigation.ts	`47.51% <ø> (+1.90%)`	⬆️
... and 14 files with indirect coverage changes

melvin-bot · 2026-07-28T07:12:30Z

@abdulrahuman5196 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

robertjchen

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Android: mWeb Chrome

iOS: HybridApp

iOS: mWeb Safari

MacOS: Chrome / Safari

MonilBhavsar · 2026-07-28T07:20:36Z

Thanks Robert!

github-actions · 2026-07-28T07:22:55Z

🚧 MonilBhavsar has triggered a test Expensify/App build. You can view the workflow run here.

OSBotify · 2026-07-28T07:26:53Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2026-07-28T07:27:54Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #97198.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-fae30faa765-45cfa58-c9ef228795bbb0a6629bf0f044f0f16f0d33c3c5/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-fae30fa-45cfa58-5a786c2029cd80946cadbde248d9830cfe1ffe31/index.html

Web 🕸️
https://97198.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

[CP staging] Revert "Navigate to the clicked expense in a multi-expense report preview- #92546" (cherry picked from commit fae30fa) (cherry-picked to staging by roryabraham)

OSBotify · 2026-07-28T07:57:54Z

🚀 Cherry-picked to staging by https://github.com/roryabraham in version: 9.4.45-3 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	failure ❌

MelvinBot · 2026-07-28T08:00:54Z

🤖 No help site changes required.

This PR reverts the "Navigate to the clicked expense in a multi-expense report preview" feature — a purely internal frontend navigation behavior change (which screen/panel opens when you tap an individual expense inside a multi-expense report preview, and the "View" vs. primary-button layout in ReportPreviewActionButton).

I reviewed the help articles that touch report previews — most relevantly Getting-Started-with-the-Spend-Page.md. They document what report previews are (summaries in the Inbox, up to 10 expense previews, inline cell editing, real-time updates) but do not document the specific tap-to-open navigation micro-interaction that this revert changes. Nothing in docs/articles describes the reverted behavior, so there is no help content to update or roll back.

No draft PR was created since there are no docs changes to make (and therefore no help site PR to link/review). If you believe a specific article does describe this behavior and should be updated, let me know which one and I'll take another look.

OSBotify · 2026-07-28T23:48:45Z

🚀 Cherry-picked to staging by https://github.com/roryabraham in version: 9.4.45-10 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

MelvinBot · 2026-07-28T23:51:27Z

🤖 Help site review: no docs changes required.

This PR reverts Navigate to the clicked expense in a multi-expense report preview, restoring the prior behavior. The reverted change affected two things:

Click behavior in the multi-expense report preview carousel — clicking an expense card opened that specific expense; the revert returns it to opening the parent report.
A grey "View" button in the preview's action row — the revert removes it.

Neither of these is documented in App/docs/articles. The only relevant article, Getting Started with the Spend Page, describes report previews only at a high level:

It lists preview contents and mentions carousel navigation and an action button (Submit, Approve, Pay, etc.) — it never documents what tapping an individual expense card does, nor a "View" button (lines 20-28).
The "Click an expense to view or edit it in the right-hand panel" line (line 52) is under the Report Tables section (the list view inside a report on the Spend page), not the in-chat report preview affected here.

The existing help content stays accurate after the revert, so there's nothing to update and no draft PR was created.

OSBotify · 2026-07-29T20:21:51Z

🚀 Deployed to production by https://github.com/marcaaron in version: 9.4.45-14 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Bundle Size Analysis (Sentry):

Android

OSBotify · 2026-07-29T21:22:01Z

🚀 Cherry-picked to staging by https://github.com/roryabraham in version: 9.4.46-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

MelvinBot · 2026-07-29T21:24:53Z

🤖 No help site changes required.

This PR reverts the "navigate to the clicked expense in a multi-expense report preview" behavior — a purely internal navigation change (which report/expense route opens when you tap an expense inside a report preview). It restores the prior behavior where tapping a preview opens the report itself.

I reviewed App/docs/articles and the only article touching report previews is Getting-Started-with-the-Spend-Page.md. Its Report Previews section documents what a preview shows (report title/status, up to 10 expense previews, carousel navigation, action buttons) — it does not document the tap-to-navigate destination that this PR changes. The "Click an expense to view or edit it in the right-hand panel" line lives under the Report table section, which this PR does not affect.

Since no published help-site content describes the behavior being reverted, there's nothing to update — so I haven't created a draft docs PR. If you'd prefer I document the report-preview tap behavior more generally, let me know and I'll open one.

OSBotify · 2026-07-31T07:37:44Z

🚀 Deployed to production by https://github.com/marcaaron in version: 9.4.46-10 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Bundle Size Analysis (Sentry):

Android

Revert "Merge pull request #92546 from wildan-m/wildan/91042-multi-ex…

edbd82e

…pense-preview-per-item-nav" This reverts commit fd93ec9, reversing changes made to 8a12457.

melvin-bot Bot assigned MonilBhavsar Jul 28, 2026

Fix cpsell

9ba36e0

MonilBhavsar changed the title ~~Revert "Navigate to the clicked expense in a multi-expense report preview- #92546"~~ [CP staging] Revert "Navigate to the clicked expense in a multi-expense report preview- #92546" Jul 28, 2026

MonilBhavsar marked this pull request as ready for review July 28, 2026 07:12

MonilBhavsar requested review from a team as code owners July 28, 2026 07:12

melvin-bot Bot requested review from abdulrahuman5196 and trjExpensify July 28, 2026 07:12

melvin-bot Bot removed request for a team and trjExpensify July 28, 2026 07:12

robertjchen approved these changes Jul 28, 2026

View reviewed changes

MonilBhavsar merged commit fae30fa into main Jul 28, 2026
46 checks passed

MonilBhavsar deleted the monil-revertExpenseTapPR branch July 28, 2026 07:20

OSBotify added the CP Staging marks PRs that have been CP'd to staging label Jul 28, 2026

OSBotify mentioned this pull request Jul 28, 2026

Deploy Checklist: New Expensify 2026-07-27 #97134

Closed

This was referenced Jul 28, 2026

[Due for payment 2026-08-05] Android - Expense - Back button returns to LHN after splitting expense #97183

Closed

[Due for payment 2026-08-05] Android - Report -After deleting expense from details page, back button leads to report again #97184

Closed

wildan-m mentioned this pull request Jul 29, 2026

Navigate to the clicked expense in a multi-expense report preview (v2) #97308

Draft

2 tasks

This was referenced Jul 29, 2026

[Due for payment 2026-08-05] Android - Report - App crashes after keeping one duplicate expense. #97158

Closed

[Due for payment 2026-08-05] Report - Expense deleted offline can still be opened and leads to "It´s not here" RHP. #97149

Closed

Uh oh!

Conversation

MonilBhavsar commented Jul 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

codecov Bot commented Jul 28, 2026 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

melvin-bot Bot commented Jul 28, 2026

Uh oh!

robertjchen left a comment

Choose a reason for hiding this comment

Reviewer Checklist

Screenshots/Videos

Uh oh!

MonilBhavsar commented Jul 28, 2026

Uh oh!

Uh oh!

github-actions Bot commented Jul 28, 2026

Uh oh!

OSBotify commented Jul 28, 2026

Uh oh!

github-actions Bot commented Jul 28, 2026

Uh oh!

OSBotify commented Jul 28, 2026

Uh oh!

MelvinBot commented Jul 28, 2026

Uh oh!

OSBotify commented Jul 28, 2026

Uh oh!

MelvinBot commented Jul 28, 2026

Uh oh!

OSBotify commented Jul 29, 2026

Uh oh!

OSBotify commented Jul 29, 2026

Uh oh!

MelvinBot commented Jul 29, 2026

Uh oh!

OSBotify commented Jul 31, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

MonilBhavsar commented Jul 28, 2026 •

edited

Loading

codecov Bot commented Jul 28, 2026 •

edited by github-actions Bot

Loading