Add Canadian Multiple Tax Export template to New Expensify for workspaces using CAD - #97255
Add Canadian Multiple Tax Export template to New Expensify for workspaces using CAD#97255dukenv0307 wants to merge 2 commits into
Conversation
|
Hey, I noticed you changed If you want to automatically generate translations for other locales, an Expensify employee will have to:
Alternatively, if you are an external contributor, you can run the translation script locally with your own OpenAI API key. To learn more, try running: npx ts-node ./scripts/generateTranslations.ts --helpTypically, you'd want to translate only what you changed by running |
|
@thelullabyy Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 336335be51
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| } | ||
|
|
||
| // The Canadian Multiple Tax Export template is only relevant to workspaces that output in CAD, so it's hidden for every other currency | ||
| if (policy?.outputCurrency === CONST.CURRENCY.CAD) { |
There was a problem hiding this comment.
Include outputCurrency in exported-to policy projections
When this helper is reused by useExportedToFilterOptions, the policies come from exportedToPoliciesSelector, which currently projects only id, name, connections, and exportLayouts; it drops outputCurrency. For CAD workspaces this condition is therefore false in autocomplete/filter hydration, so users can export with Canadian Multiple Tax from the menu but cannot discover or preserve exported_to:"Canadian Multiple Tax Export" in search filters. Please include outputCurrency in that selector or avoid relying on a field those callers strip.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
@dukenv0307 Could you please check this commetn?
Reviewer Checklist
Screenshots/VideosiOS: HybridAppScreen.Recording.2026-08-02.at.18.03.34.movMacOS: Chrome / SafariScreen.Recording.2026-08-02.at.17.43.32.mov |
|
@thelullabyy are you able to review this? 🙇 |
|
Reviewing now |
NikkiWines
left a comment
There was a problem hiding this comment.
@dukenv0307 please fill out the QA section 🙇
Explanation of Change
Fixed Issues
$ #97231
PROPOSAL:
Tests
Offline tests
QA Steps
// TODO: These must be filled out, or the issue title must include "[No QA]."
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)Avatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
Screen.Recording.2026-07-28.at.11.27.32.PM.mov