[No QA] Cleanup unsafe type assertions in tests

[KJ21-ENG]

Explanation of Change

This test-only cleanup removes 60 @typescript-eslint/no-unsafe-type-assertion violations from the ten requested test files while preserving their test behavior. No application UI, production logic, CSS, assets, messaging behavior, generic components, Storybook stories, or deeplink behavior changed.

Fixed Issues

$ #94739
PROPOSAL: #94739 (comment)

Count change

Current baseline source:

• config/eslint/eslint.seatbelt.tsv at exact rebuild base cb505a9c1064af2d0c910e6fa841305c5b640df5, SHA-256 81ca0465651537862a00f0886d26cead5ffeaea388772ca565bb0f28737e7e30.
• Target rule: @typescript-eslint/no-unsafe-type-assertion.

Before:

• tests/ui/SelectCountryStepTest.tsx: 6 violations.
• tests/unit/AddExistingExpenseSearchTest.ts: 6 violations.
• tests/unit/EmojiReactionsTest.ts: 6 violations.
• tests/unit/LoadTestMiddlewareTest.ts: 6 violations.
• tests/unit/LogTest.ts: 6 violations.
• tests/unit/ModifiedExpenseMessageTest.ts: 6 violations.
• tests/unit/Navigation/createRootStackNavigator/handleReplaceFullscreenUnderRHP.test.ts: 6 violations.
• tests/unit/NetworkTest.tsx: 6 violations.
• tests/unit/hooks/useConfirmationValidation.test.ts: 6 violations.
• tests/unit/hooks/usePendingConciergeResponse.test.ts: 6 violations.

After:

• tests/ui/SelectCountryStepTest.tsx: 0 violations.
• tests/unit/AddExistingExpenseSearchTest.ts: 0 violations.
• tests/unit/EmojiReactionsTest.ts: 0 violations.
• tests/unit/LoadTestMiddlewareTest.ts: 0 violations.
• tests/unit/LogTest.ts: 0 violations.
• tests/unit/ModifiedExpenseMessageTest.ts: 0 violations.
• tests/unit/Navigation/createRootStackNavigator/handleReplaceFullscreenUnderRHP.test.ts: 0 violations.
• tests/unit/NetworkTest.tsx: 0 violations.
• tests/unit/hooks/useConfirmationValidation.test.ts: 0 violations.
• tests/unit/hooks/usePendingConciergeResponse.test.ts: 0 violations.

Net reduction:

• 60 fewer unsafe type assertion violations across the ten targets.

TSV evidence:

• The exact-head verification restored config/eslint/eslint.seatbelt.tsv; its content matches the recorded exact-base digest above.
• The complete diff contains only the ten requested test files; no support paths or generated inventory changes are published.

Tests

1. Complete exact-head verification reported zero remaining target violations for all ten files.
2. Focused formatting, focused lint, focused Jest, and git diff --check passed; generated TSV restoration and exact changed-path validation also passed.
3. The verifier-owned focused typecheck was partial/unavailable because its only diagnostic was outside the authorized paths at src/components/AddressSearch/index.tsx:420; no authorized-path diagnostic was reported.
4. Exact-head Fork CI passed all required checks at provider run 30619982299: typecheck, lint, format, React Compiler, and Jest.

Manual JS-console verification: N/A — this is test-only cleanup with no application runtime change.

Offline tests

N/A — this is test-only type cleanup; no network, offline, or synchronization behavior changed.

QA Steps

N/A — this is test-only cleanup with no staging or production behavior change. The title starts with [No QA].

Verify that no errors appear in the JS console: N/A — no application runtime code changed.

PR Author Checklist

For checklist items that are not applicable to this test-only cleanup, checked means the item was considered and determined not applicable.

• I linked the correct issue in the ### Fixed Issues section above
• I wrote clear testing steps that cover the changes made in this PR
  • I added steps for local testing in the Tests section
  • I added steps for the expected offline behavior in the Offline steps section
  • I added steps for Staging and/or Production testing in the QA steps section
  • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
• I included screenshots or videos for tests on all platforms
• I ran the tests on all platforms & verified they passed on:
  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
• I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
• I followed proper code patterns (see Reviewing the code)
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I followed the guidelines as stated in the Review Guidelines
• I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
• If new assets were added or existing ones were modified, I verified that:
  • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
  • The assets load correctly across all supported platforms.
• If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
  • I verified that all the inputs inside a form are aligned with each other.
  • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
• I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native — N/A; no UI or visual behavior changed.

Android: mWeb Chrome — N/A; no UI or visual behavior changed.

iOS: Native — N/A; no UI or visual behavior changed.

iOS: mWeb Safari — N/A; no UI or visual behavior changed.

MacOS: Chrome / Safari — N/A; no UI or visual behavior changed.

Changed files (10)

• tests/ui/SelectCountryStepTest.tsx
• tests/unit/AddExistingExpenseSearchTest.ts
• tests/unit/EmojiReactionsTest.ts
• tests/unit/LoadTestMiddlewareTest.ts
• tests/unit/LogTest.ts
• tests/unit/ModifiedExpenseMessageTest.ts
• tests/unit/Navigation/createRootStackNavigator/handleReplaceFullscreenUnderRHP.test.ts
• tests/unit/NetworkTest.tsx
• tests/unit/hooks/useConfirmationValidation.test.ts
• tests/unit/hooks/usePendingConciergeResponse.test.ts

[melvin-bot]

@ikevin127 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

[ikevin127]

Reviewer Checklist

• I have verified the author checklist is complete (all boxes are checked off).
• I verified the correct issue is linked in the ### Fixed Issues section above
• I verified testing steps are clear and they cover the changes made in this PR
  • I verified the steps for local testing are in the Tests section
  • I verified the steps for Staging and/or Production testing are in the QA steps section
  • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
• I checked that screenshots or videos are included for tests on all platforms
• I included screenshots or videos for tests on all platforms
• I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
• I verified tests pass on all platforms & I tested again on:
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
• If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
• I verified proper code patterns were followed (see Reviewing the code)
  • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I verified that this PR follows the guidelines as stated in the Review Guidelines
• I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
• If a new component is created I verified that:
  • A similar component doesn't exist in the codebase
  • All props are defined accurately and each prop has a /** comment above it */
  • The file is named correctly
  • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
  • The only data being stored in the state is data necessary for rendering and nothing else
  • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
  • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
  • All JSX used for rendering exists in the render method
  • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
• If any new file was added I verified that:
  • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
• If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
  • I verified that all the inputs inside a form are aligned with each other.
  • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
• For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
• I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

[ikevin127]

🟢 LGTM

Notes (no change requested)

• createMock<T> is the same pre-existing, PartialDeep<T>-checked shared helper vetted on #97284: wrong fields/types are still caught at each call site. Confirmed it is imported in every file that uses it, including ModifiedExpenseMessageTest.ts (pre-existing import at line 18, so the diff not showing the import is expected, not a compile break).
• LoadTestMiddlewareTest.ts: TestHelper.setupGlobalFetchMock() is a real typed helper returning MockFetch, and switching to native FormData.get()/has() (dropping the local formBodyToObject and FetchMockCall type) is cleaner and cast-free.
• handleReplaceFullscreenUnderRHP.test.ts: nicely done, [...] satisfies PartialState<...>['routes'] instead of as, ROUTES.WORKSPACE_INITIAL.getRoute('NEW') instead of '/workspaces/NEW' as Route, and the stackRouter.getRehydratedState guard (if (partialState.stale !== false) throw) doubles as the union-narrowing that lets it return without a cast.
• LogTest.ts: the new isLogLine / isLogInfoParameters guards are test-local, but they validate deserialized JSON (a log packet) where no production guard exists, and LogInfoParameters is derived from Parameters<typeof Log.info>[2], not duplicated. They replace an unsafe JSON.parse(...) as LogLine[] with real runtime validation, so they earn their place.
• NetworkTest.tsx / usePendingConciergeResponse.test.ts: jest.SpiedFunction<typeof X> + jest.spyOn replace jest.fn() + as jest.Mock, and the removed local LogInfoCall type is now covered by the typed spy. Good ✅