Skip to content

Hide duplicate Concierge row on Help page when guide/AM/relationship manager is Concierge - #97293

Draft
MelvinBot wants to merge 2 commits into
mainfrom
claude-hideDuplicateConciergeHelpRow
Draft

Hide duplicate Concierge row on Help page when guide/AM/relationship manager is Concierge#97293
MelvinBot wants to merge 2 commits into
mainfrom
claude-hideDuplicateConciergeHelpRow

Conversation

@MelvinBot

Copy link
Copy Markdown
Contributor

Explanation of Change

The Help page (Account > Help) always renders a dedicated Concierge button ("Your personal AI agent"). It separately renders a guide / account manager / partner (relationship) manager row whenever the corresponding details exist — but it never checked whether that contact is actually Concierge. When Concierge is assigned to any of those slots, Concierge was shown twice on the page.

This change adds an isConciergePersonalDetail guard (matching on accountID === CONST.ACCOUNT_ID.CONCIERGE or login === CONST.EMAIL.CONCIERGE) and gates the partnerManagerItem, guideItem, and accountManagerItem on it, so any of those slots resolving to Concierge is treated as empty. Gating at item construction keeps hasActiveItem correct, so when no real human contact remains the original Concierge button falls back into the "More resources" list alongside Help Site — exactly the intended "keep the original Concierge button and Help Site only" behavior.

Fixed Issues

$ #92727
PROPOSAL: #92727 (comment)

Tests

// TODO: The human co-author must fill out the manual tests they ran before marking this PR as "ready for review".

Automated coverage added in tests/ui/HelpPageTest.tsx:

  1. Hides the account manager row when the account manager is Concierge (only the dedicated Concierge button remains).
  2. Hides the guide row when the guide is Concierge (resolved by email).
  3. Still renders a non-Concierge account manager row normally.
  • Verify that no errors appear in the JS console

Offline tests

N/A — this is a display-only change on the Help page and does not change any network behavior.

QA Steps

// TODO: The human co-author must fill out the QA steps before marking this PR as "ready for review".

Suggested:

  1. Sign in with an account that has Concierge assigned as its guide / account manager / relationship manager.
  2. Go to Account > Help.
  3. Verify Concierge appears only once (the "Your personal AI agent" button) plus the Help Site entry — no duplicate Concierge row.
  4. With a human guide / account manager / relationship manager assigned, verify that row still renders normally.
  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari

MelvinBot and others added 2 commits July 28, 2026 22:53
…er resolves to Concierge

Co-authored-by: Manan <mananjadhav@users.noreply.github.com>
Co-authored-by: Manan <mananjadhav@users.noreply.github.com>
@codecov

codecov Bot commented Jul 28, 2026

Copy link
Copy Markdown

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines Coverage Δ
src/pages/settings/HelpPage/HelpPage.tsx 84.37% <58.33%> (+0.50%) ⬆️
... and 36 files with indirect coverage changes

@MelvinBot

Copy link
Copy Markdown
Contributor Author

I analyzed the checks — there's no code failure to fix. ✅

Every substantive check passes: typecheck, all 8 test jobs, ESLint, Oxfmt, React Compiler Compliance, Storybook tests, Bun tests, codecov/patch + codecov/project, the perf tests, and all builds.

The only red check is PR Author Checklist / checklist, which fails with:

You completed 0 out of 38 checklist items with 38 unfinished items

That's expected on this PR — it's not a code/CI problem and can't be resolved by pushing a commit. It needs the human co-author to:

  1. Fill out the Tests and QA Steps sections (currently // TODO).
  2. Check off the boxes in the PR Author Checklist.

Once the checklist boxes are ticked, that check will pass. Let me know if you'd like me to look into anything else.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants