Hide duplicate Concierge row on Help page when guide/AM/relationship manager is Concierge - #97293
Draft
MelvinBot wants to merge 2 commits into
Draft
Hide duplicate Concierge row on Help page when guide/AM/relationship manager is Concierge#97293MelvinBot wants to merge 2 commits into
MelvinBot wants to merge 2 commits into
Conversation
…er resolves to Concierge Co-authored-by: Manan <mananjadhav@users.noreply.github.com>
Co-authored-by: Manan <mananjadhav@users.noreply.github.com>
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
Contributor
Author
|
I analyzed the checks — there's no code failure to fix. ✅ Every substantive check passes: The only red check is
That's expected on this PR — it's not a code/CI problem and can't be resolved by pushing a commit. It needs the human co-author to:
Once the checklist boxes are ticked, that check will pass. Let me know if you'd like me to look into anything else. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
The Help page (
Account > Help) always renders a dedicated Concierge button ("Your personal AI agent"). It separately renders a guide / account manager / partner (relationship) manager row whenever the corresponding details exist — but it never checked whether that contact is actually Concierge. When Concierge is assigned to any of those slots, Concierge was shown twice on the page.This change adds an
isConciergePersonalDetailguard (matching onaccountID === CONST.ACCOUNT_ID.CONCIERGEorlogin === CONST.EMAIL.CONCIERGE) and gates thepartnerManagerItem,guideItem, andaccountManagerItemon it, so any of those slots resolving to Concierge is treated as empty. Gating at item construction keepshasActiveItemcorrect, so when no real human contact remains the original Concierge button falls back into the "More resources" list alongside Help Site — exactly the intended "keep the original Concierge button and Help Site only" behavior.Fixed Issues
$ #92727
PROPOSAL: #92727 (comment)
Tests
// TODO: The human co-author must fill out the manual tests they ran before marking this PR as "ready for review".
Automated coverage added in
tests/ui/HelpPageTest.tsx:Offline tests
N/A — this is a display-only change on the Help page and does not change any network behavior.
QA Steps
// TODO: The human co-author must fill out the QA steps before marking this PR as "ready for review".
Suggested:
Account > Help.PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari