Skip to content

fix: surface empty draft reports in Submit to-do bucket - #97312

Open
c3024 wants to merge 2 commits into
Expensify:mainfrom
c3024:chaitanya/659302-empty-drafts-submit-todo
Open

fix: surface empty draft reports in Submit to-do bucket#97312
c3024 wants to merge 2 commits into
Expensify:mainfrom
c3024:chaitanya/659302-empty-drafts-submit-todo

Conversation

@c3024

@c3024 c3024 commented Jul 29, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Explanation of Change

reportMatchesTodoBucket's Submit bucket only matched reports where isSubmitAction returned true, which requires at least one non-held transaction. Empty (zero-transaction) draft reports have no Submit action, so they never appeared in the Search "Submit" to-do or the Drafts tab even though they carry a Draft badge.

For the Submit bucket, an open, non-archived report on a group policy that is owned by the current user and has zero transactions is now included, matching the companion Auth-side fix to the Submit search filter (https://github.com/Expensify/Auth/pull/23306).

Fixed Issues

$ https://github.com/Expensify/Expensify/issues/659302
PROPOSAL:

Tests

  1. Create an open expense report with no expenses added, on a group workspace, owned by you.
  2. Open the Drafts tab / check the "Submit" to-do.
  3. Verify the empty report is listed alongside reports that have unheld, unsubmitted expenses.
  4. Verify an empty report you don't own, and an empty report on a personal policy are still excluded.
  5. Verify that no errors appear in the JS console
Screen.Recording.2026-07-29.at.1.10.23.PM.mov

Offline tests

Same as Tests - the to-do bucket is computed from local Onyx data, so offline behavior is unaffected.

QA Steps

Same as Tests

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
Screen.Recording.2026-07-29.at.1.10.23.PM.mov

@c3024
fix: surface empty draft reports in Submit to-do bucket
ea43cae 
Empty (zero-transaction) open expense reports have no Submit action,
so they were excluded from the Submit to-do bucket even though they
carry a Draft badge and belong in the Drafts tab. Owned, non-archived
empty drafts on a group policy now surface alongside reports that are
actually awaiting submission.
@c3024 c3024 changed the title fix: surface empty draft reports in Submit to-do bucket [HOLD] fix: surface empty draft reports in Submit to-do bucket Jul 29, 2026
@c3024 c3024 changed the title [HOLD] fix: surface empty draft reports in Submit to-do bucket fix: surface empty draft reports in Submit to-do bucket Jul 31, 2026
@c3024

c3024 commented Jul 31, 2026

Copy link
Copy Markdown
Contributor Author

@codex review

@c3024
c3024 marked this pull request as ready for review July 31, 2026 06:43
@c3024
c3024 requested review from a team as code owners July 31, 2026 06:43
@melvin-bot
melvin-bot Bot requested review from JmillsExpensify and gijoe0295 and removed request for a team July 31, 2026 06:43
@melvin-bot

melvin-bot Bot commented Jul 31, 2026

Copy link
Copy Markdown

@gijoe0295 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot
melvin-bot Bot removed the request for review from a team July 31, 2026 06:43
@c3024
c3024 requested review from a team and JS00001 July 31, 2026 06:43
@melvin-bot
melvin-bot Bot requested review from trjExpensify and removed request for a team July 31, 2026 06:43
@c3024

c3024 commented Jul 31, 2026

Copy link
Copy Markdown
Contributor Author

@flaviadefaria

From here,

Am I able to trigger a test build in an auth PR? I'd love to see how it would look if the user had multiple draft reports (e.g., one with expenses and 2 without).

This can be tested on this PR with an adhoc build.

chatgpt-codex-connector[bot]
chatgpt-codex-connector Bot reviewed Jul 31, 2026
View reviewed changes

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: ea43cae1d9

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment thread src/libs/TodosUtils.ts Outdated
@c3024
Gate empty-draft submit classification on transaction load status
91b4ea5 
Unloaded transactions look identical to zero transactions, so a report could briefly be misclassified as an empty draft before its transactions finished hydrating.
@c3024

c3024 commented Jul 31, 2026

Copy link
Copy Markdown
Contributor Author

@codex review.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Jul 31, 2026

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Delightful!

Reviewed commit: 91b4ea5204

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chatgpt-codex-connector chatgpt-codex-connector[bot] chatgpt-codex-connector[bot] left review comments
@JS00001 JS00001 JS00001 approved these changes
@gijoe0295 gijoe0295 Awaiting requested review from gijoe0295
@JmillsExpensify JmillsExpensify Awaiting requested review from JmillsExpensify
@trjExpensify trjExpensify Awaiting requested review from trjExpensify

Assignees

@c3024 c3024

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@c3024 @JS00001