[NO QA] Fix typecheck break on main from convertToDisplayString migration - #97723
Conversation
|
@QichenZhu Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚧 Beamanator has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
🚀 Deployed to staging by https://github.com/Beamanator in version: 9.4.49-0 🚀
|
|
🤖 I reviewed this PR against the help site files under Why: This is a build-break fix only. The diff restores an aliased The cross-border FX payment copy referenced here already existed on No draft docs PR was created, since there's nothing user-facing to document. @blimpich, let me know if you'd like me to reconsider any specific flow this touches. |
Explanation of Change
mainis currently red on typecheck, lint, and jest.PR #97245 (part 14 of the
convertToDisplayStringmigration) last ran CI on 2026-07-28 and removed the module-levelconvertToDisplayStringimport fromReportActionsUtils. PR #96901 merged after that, on 2026-07-31, and added cross-border FX payment messages that callconvertToDisplayStringdirectly. The two PRs touch different lines, so git merged them cleanly, but the identifier no longer exists — a semantic conflict that only surfaced once part 14 landed onmain.This restores the aliased
CurrencyUtilsimport at the two call sites that build report-action copy outside of a hook context, matching how the sibling call sites in the same functions are already written, and updates the test call sites for the new signatures ofgetReportPreviewMessageandgetIOUReportActionDisplayMessage.No behavior changes.
Fixed Issues
$ #97722
$ #97721
$ #97720
$ #97719
$ #97718
PROPOSAL: N/A
Tests
Offline tests
N/A — no network-dependent behavior changes.
QA Steps
N/A — no user-facing change. Build-break fix only, verified by CI.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
N/A — no UI change.
Android: mWeb Chrome
N/A — no UI change.
iOS: Native
N/A — no UI change.
iOS: mWeb Safari
N/A — no UI change.
MacOS: Chrome / Safari
N/A — no UI change.
– written by Claude on Ben's behalf