[No QA] Give each INP path its own Sentry label - #97794
Conversation
MoneyRequest-ConfirmationSubmitButton covered the submit, split, track and invoice flows, and IOURequestStep-ScanSubmitButton covered three unrelated buttons. A Sentry label aggregates every interaction that shares it, so both reported one blended INP series that could not be attributed to a code path. Split them so each path reports on its own. The confirmation CTA keeps CONFIRMATION_SUBMIT_BUTTON for the submit flow to preserve its existing series and derives split/track/invoice from iouType. SCAN_SUBMIT_BUTTON is retired in favour of labels named after the buttons that actually used it: the web file upload picker and the web and native camera permission prompts.
|
@codex review |
|
Codex Review: Didn't find any major issues. Delightful! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppAndroid: mWeb ChromeiOS: HybridAppiOS: mWeb SafariMacOS: Chrome / Safari |
|
🚧 Valforte has triggered a test Expensify/App build. You can view the workflow run here. |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
🚀 Deployed to staging by https://github.com/Valforte in version: 9.4.50-0 🚀
|
|
🤖 No help site changes required. I reviewed the changes in this PR and they don't need any updates to Expensify's help site files under Why: This PR only splits internal Sentry performance-monitoring labels ( Since there's no help site PR to link, there's nothing further needed on the docs side here. |
|
🚀 Deployed to production by https://github.com/arosiclair in version: 9.4.50-3 🚀
Bundle Size Analysis (Sentry): |
Explanation of Change
Split
CONFIRMATION_SUBMIT_BUTTONandSCAN_SUBMIT_BUTTONinto more granular labels so we can better track which INP is slow.Fixed Issues
For #76128
PROPOSAL:
Tests
Offline tests
N/A
QA Steps
NO QA
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari