Skip to content

Revert 97896 and 97521 - #97900

Merged
arosiclair merged 3 commits into
mainfrom
arosiclair-revert-97896-and-97521
Aug 5, 2026
Merged

Revert 97896 and 97521#97900
arosiclair merged 3 commits into
mainfrom
arosiclair-revert-97896-and-97521

Conversation

@arosiclair

@arosiclair arosiclair commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

Reverts #97896 and #97521 if needed

$ #97907

…nUseTrackFlows"

This reverts commit df7808c, reversing
changes made to b5e3fbf.
…est-part-2-v3"

This reverts commit 8d50697, reversing
changes made to 2f32f04.
@arosiclair arosiclair self-assigned this Aug 5, 2026
@arosiclair arosiclair changed the title Revert 97896 and 97521 [HOLD] Revert 97896 and 97521 Aug 5, 2026
@arosiclair
arosiclair marked this pull request as ready for review August 5, 2026 19:39
@arosiclair
arosiclair requested review from a team as code owners August 5, 2026 19:39
@melvin-bot
melvin-bot Bot requested review from garrettmknight and stitesExpensify and removed request for a team August 5, 2026 19:39
@melvin-bot

melvin-bot Bot commented Aug 5, 2026

Copy link
Copy Markdown

@stitesExpensify Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@arosiclair
arosiclair removed the request for review from garrettmknight August 5, 2026 19:40
@codecov

codecov Bot commented Aug 5, 2026

Copy link
Copy Markdown

@arosiclair arosiclair changed the title [HOLD] Revert 97896 and 97521 Revert 97896 and 97521 Aug 5, 2026
@arosiclair
arosiclair merged commit 6db4e8a into main Aug 5, 2026
45 of 46 checks passed
@arosiclair
arosiclair deleted the arosiclair-revert-97896-and-97521 branch August 5, 2026 21:11
@github-actions

github-actions Bot commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

🚧 arosiclair has triggered a test Expensify/App build. You can view the workflow run here.

@OSBotify

OSBotify commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify pushed a commit that referenced this pull request Aug 5, 2026
…97521

Revert 97896 and 97521

(cherry picked from commit 6db4e8a)

(cherry-picked to staging by arosiclair)
@OSBotify OSBotify added the CP Staging marks PRs that have been CP'd to staging label Aug 5, 2026
@OSBotify

OSBotify commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

🚀 Cherry-picked to staging by https://github.com/arosiclair in version: 9.4.50-2 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 cancelled 🔪
🍎 iOS 🍎 cancelled 🔪

@MelvinBot

Copy link
Copy Markdown
Contributor

🤖 Help site review — no changes required

I reviewed the changes in this PR against Expensify's help site files under docs/articles. No help site updates are needed.

This PR is a revert of PRs #97896 and #97521, and every change is internal navigation plumbing with no user-facing impact:

  • Converts the MONEY_REQUEST_UPGRADE / MONEY_REQUEST_ACCOUNTANT dynamic routes back to static routes in src/ROUTES.ts
  • Renames screen constants in src/SCREENS.ts (DYNAMIC_STEP_UPGRADESTEP_UPGRADE, DYNAMIC_STEP_ACCOUNTANTSTEP_ACCOUNTANT)
  • Renames a route param (upgradeBackTobackTo) and updates the corresponding call sites
  • Updates navigation config, types, permissions, and unit/navigation tests

None of this alters any feature name, tab name, settings label, button, or documented workflow — the help site describes user-facing behavior, and that behavior is unchanged by this revert. There are no strings, UI copy, or product-behavior changes to reflect in docs/articles.

Since no docs changes are required, I did not open a draft help site PR.

@arosiclair, please confirm this assessment is correct — that the reverted changes are internal-only and don't require any help site updates. If you believe a docs update is needed, let me know and I'll create the draft PR.

@OSBotify

OSBotify commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/arosiclair in version: 9.4.50-3 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Bundle Size Analysis (Sentry):

@OSBotify

OSBotify commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

🚀 Cherry-picked to staging by https://github.com/arosiclair in version: 9.4.51-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CP Staging marks PRs that have been CP'd to staging

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants