Skip to content

[TESTING ONLY] Pin react-native-onyx to disk-pressure classification (Onyx PR #816) - #97944

Draft
elirangoshen wants to merge 2 commits into
Expensify:mainfrom
callstack-internal:eliran/pin-onyx-816-disk-pressure
Draft

[TESTING ONLY] Pin react-native-onyx to disk-pressure classification (Onyx PR #816)#97944
elirangoshen wants to merge 2 commits into
Expensify:mainfrom
callstack-internal:eliran/pin-onyx-816-disk-pressure

Conversation

@elirangoshen

@elirangoshen elirangoshen commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

Explanation of Change

This is a TESTING ONLY companion PR for the react-native-onyx PR Expensify/react-native-onyx#816 ("Classify SQLite disk-pressure errors and stop retrying them"). It is not intended to merge as-is: once Onyx #816 merges and ships in a released version, this PR will either be updated to the released npm version or closed in favor of the regular version bump.

The only change here is pinning react-native-onyx in package.json / package-lock.json from 3.0.92 to the Onyx PR's head commit (callstack-internal/react-native-onyx#c78c578, branch eliran/87869-classify-disk-pressure, which resolves to version 3.0.94 from the git ref), so the full E/App CI suite and adhoc builds can exercise the Onyx change, per the onyx repo's "Linked E/App PR" requirement.

What Onyx #816 does: addresses the app-side symptom of #87869 — iOS bursts of NitroSQLiteError: ... disk I/O error (Sentry APP-19Q) caused by a full device disk at database (re)open (SQLITE_IOERR_SHMSIZE on the -shm WAL-index file, plus the related unable to open database file and cannot rollback - no transaction is active shapes). Previously these fell in the UNKNOWN storage error class: 5 blind retries per operation plus a per-operation alert, amplifying the log storm (~70x amplification seen in prod logs). The Onyx PR:

  • Adds a new DISK_PRESSURE storage error class and routes the two SQLite full-disk error messages to it (disk I/O error, unable to open database file); cannot rollback - no transaction is active deliberately stays UNKNOWN since it is a mask, not a cause
  • Stops retrying and stops cache eviction on these errors (neither can free OS-level disk space; the in-memory cache stays authoritative)
  • Logs a single throttled alert (60s window) plus one storage quota snapshot per burst, including getFreeDiskStorage() bytes on native so prod telemetry can confirm disk pressure as the root cause

Fixed Issues

$ #87869
$ #97908
PROPOSAL: N/A (testing-only dependency-pin companion PR; the change itself is reviewed in Expensify/react-native-onyx#816)

Automated Tests

Automated coverage for the change lives in the paired onyx PR (Expensify/react-native-onyx#816), in tests/unit/onyxUtilsTest.ts: an it.each over the two disk-pressure error strings asserting the operation is not retried, and a burst test asserting exactly one throttled alert + one storage quota snapshot per burst. This PR only pins the dependency so the full E/App CI suite runs against it.

Tests

Regression smoke only — the pinned Onyx change alters internal error classification/logging with no user-facing behavior change:

  1. Sign in and use the app normally: open a report, create an expense, send a message.
  2. Kill and relaunch the app — verify data loads correctly.
  3. Verify no crashes or console errors during normal usage.
  • Verify that no errors appear in the JS console

Offline tests

  1. Go offline, create an expense, kill and relaunch the app — verify the offline change is still there and syncs when back online.

QA Steps

Same as Tests. (Testing-only PR — not intended to reach staging as-is.)

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

N/A — dependency pin only.

Android: mWeb Chrome

N/A — dependency pin only.

iOS: Native

N/A — dependency pin only.

iOS: mWeb Safari

N/A — dependency pin only.

MacOS: Chrome / Safari

N/A — dependency pin only.

…(Onyx PR Expensify#816)

Pins react-native-onyx to callstack-internal/react-native-onyx@d7abb2c7
(branch eliran/87869-classify-disk-pressure) so E/App CI runs against
Onyx PR Expensify#816's SQLite disk-pressure error classification.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@github-actions

github-actions Bot commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

⚠️ This PR is possibly changing native code and/or updating libraries, it may cause problems with HybridApp. Please check if any patch updates are required in the HybridApp repo and run an AdHoc build to verify that HybridApp will not break. Ask Contributor Plus for help if you are not sure how to handle this. ⚠️

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant