fix: Learn more banner is broken after rotating device to portrait - #97953
Conversation
|
@thelullabyy Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
joekaufmanexpensify
left a comment
There was a problem hiding this comment.
Good for product
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppScreen.Recording.2026-08-12.at.19.36.26.movAndroid: mWeb ChromeScreen.Recording.2026-08-12.at.19.40.26.moviOS: HybridAppScreen.Recording.2026-08-12.at.19.31.09.moviOS: mWeb SafariScreen.Recording.2026-08-12.at.19.13.21.mov |
|
BUG: The button in banner is out of the box @nkdengineer
|
|
@nkdengineer friendly bump |
|
@thelullabyy Fixed. |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚧 Gonals has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
🚀 Deployed to staging by https://github.com/Gonals in version: 9.4.53-0 🚀
|
|
🤖 I reviewed the changes in this PR against the help site articles under No help site changes are required. This PR is a purely visual layout fix for the Expensify Card promotion banner on the Company cards page — it swaps a flex-basis style for a min-width ( @nkdengineer, since no help site PR was created, there's nothing further to review here. If you believe a doc update is needed, let me know what behavior should be documented and I'll take another look. |


Explanation of Change
fix: Learn more banner is broken after rotating device to portrait
Fixed Issues
$ #97156
PROPOSAL: #97156 (comment)
Tests
Offline tests
QA Steps
Same as test
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Screen.Recording.2026-08-06.at.16.50.36.mp4
Android: mWeb Chrome
Screen.Recording.2026-08-12.at.15.29.25.mp4
iOS: Native
Screen.Recording.2026-08-06.at.16.52.52.mp4
iOS: mWeb Safari
Screen.Recording.2026-08-12.at.15.29.08.mp4
MacOS: Chrome / Safari
Screen.Recording.2026-08-06.at.16.56.08.mov