Skip to content

ReportActionAvatars -> UserAvatar for multi avatars migration + leftovers - #97983

Open
jmusial wants to merge 10 commits into
Expensify:mainfrom
software-mansion-labs:chore/account-avatars-for-multi-avatar-usages
Open

ReportActionAvatars -> UserAvatar for multi avatars migration + leftovers#97983
jmusial wants to merge 10 commits into
Expensify:mainfrom
software-mansion-labs:chore/account-avatars-for-multi-avatar-usages

Conversation

@jmusial

@jmusial jmusial commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

Explanation of Change

Replaces ReportActionAvatars at every call site where the accounts to render are already known, introducing three lightweight components - AccountAvatars, and AccountAvatarWithCardFeed and using AccountAvatar introduced in previous PR.

They resolve icons from the shared personal-details context via a new useAccountIcons hook instead of subscribing to report and policy Onyx keys. This drops a per-row Onyx subscription from menu items, option rows, selection lists, task previews, and card tables.

This PR also removes the now-unused shouldStackHorizontally and floatRightAvatars props from MenuItem.

Important

May overlap a but with #97961. Not in functionality, but it modifies same files.

Fixed Issues

$ #94586

PROPOSAL:

Tests

Scenario 1 — Selection list avatars, including the workspace subscript

  1. Open app.
  2. Tap the green + button and select Start chat.
  3. Verify that each personal contact row shows that person's avatar, and that hovering it (web) shows the display-name tooltip.
  4. Close RHP with chat selector
  5. Click Search icon
  6. Type the name of your workspace in the search field so the workspace chat row appears in the results.
  7. Verify that the workspace chat row shows the workspace avatar as the main avatar with the member avatar as a small subscript in the bottom-right corner.

Scenario 2 — Stacked avatars in the workspace invite flow

  1. Open app.
  2. Navigate to Settings > Workspaces > [your workspace] > Members.
  3. Tap Invite member, select three or more people (mix existing Expensify users with a brand-new email address that has no account yet), then tap Next.
  4. Verify that the invite message screen shows a horizontal row of overlapping large avatars, one per invitee, with the not-yet-registered email showing a generated fallback avatar rather than a blank or broken image.
  5. Select enough people that the avatars exceed one row, and verify they wrap onto a second row and that any overflow collapses into a "+N" indicator.
  6. Go back and deselect everyone so no invitees remain, then reach the invite message screen again.
  7. Verify that a single placeholder avatar renders in the same slot.

Offline tests

N/A

QA Steps

Same as tests

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Screen.Recording.2026-08-10.at.17.00.42.mov
Android: mWeb Chrome
Screen.Recording.2026-08-10.at.17.13.30.mov
iOS: Native
Screen.Recording.2026-08-10.at.16.55.33.mov
iOS: mWeb Safari
Screen.Recording.2026-08-10.at.16.50.34.mov
MacOS: Chrome / Safari
Screen.Recording.2026-08-10.at.16.47.49.mov

@codecov

codecov Bot commented Aug 10, 2026

Copy link
Copy Markdown

@jmusial

jmusial commented Aug 10, 2026

Copy link
Copy Markdown
Contributor Author

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. What shall we delve into next?

Reviewed commit: 4e324b8cf7

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

@jmusial
jmusial marked this pull request as ready for review August 11, 2026 09:40
@jmusial
jmusial requested review from a team as code owners August 11, 2026 09:40
@melvin-bot
melvin-bot Bot requested review from sobitneupane and trjExpensify and removed request for a team August 11, 2026 09:40
@melvin-bot

melvin-bot Bot commented Aug 11, 2026

Copy link
Copy Markdown

@sobitneupane Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@jmusial

jmusial commented Aug 11, 2026

Copy link
Copy Markdown
Contributor Author

cc. @roryabraham AccountAvatar PR 2

Comment thread src/components/Avatar/connected/useAccountIcons.ts Outdated
Comment thread src/components/MenuItem.tsx Outdated
@quinthar quinthar added the #quality Relates to work in the #quality room label Aug 11, 2026
@roryabraham
roryabraham self-requested a review August 11, 2026 20:24
@trjExpensify
trjExpensify removed their request for review August 11, 2026 22:33
@trjExpensify

Copy link
Copy Markdown
Contributor

PR doesn’t need product input as a perf PR. Unassigning and unsubscribing myself.

Comment thread src/components/Avatar/connected/MultiAccountAvatar.tsx
Comment thread src/components/Avatar/connected/AccountAvatars.tsx Outdated
Comment thread src/components/Avatar/connected/MultiAccountAvatar.tsx
@jmusial
jmusial requested a review from roryabraham August 12, 2026 12:49
@roryabraham

Copy link
Copy Markdown
Contributor

@sobitneupane this is awaiting C+ review and checklist

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

#quality Relates to work in the #quality room

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants