Skip to content

[TESTING ONLY] Pin react-native-onyx to batch-collection-removals fix (Onyx #820) - #98121

Draft
elirangoshen wants to merge 1 commit into
Expensify:mainfrom
callstack-internal:eliran/94839-batch-removals-pin
Draft

[TESTING ONLY] Pin react-native-onyx to batch-collection-removals fix (Onyx #820)#98121
elirangoshen wants to merge 1 commit into
Expensify:mainfrom
callstack-internal:eliran/94839-batch-removals-pin

Conversation

@elirangoshen

Copy link
Copy Markdown
Contributor

Explanation of Change

[TESTING ONLY — do not merge] Pins react-native-onyx to the HEAD of Expensify/react-native-onyx#820 (callstack-internal/react-native-onyx#33dd460b) so the full E/App CI suite and adhoc builds run against the fix for the two-tabs-heavy-account crash.

Onyx PR #820 batches collection member removals into a single cross-tab sync event (and skips no-op removals), and coalesces incoming sync-event floods on the receiving side. This removes the per-key transactionViolations_ event storm (~2,000 events per boot on heavy accounts) that made two tabs crash each other and blocked the Onyx bump past 3.0.95.

Fixed Issues

$ #94839
PROPOSAL:

Tests

With two NewDot tabs signed in to the same heavy account (e.g. Applause):

  1. Refresh both tabs and stay in Tab A. Wait ~30 seconds. Verify neither tab crashes and both stay responsive.
  2. In Tab A: pin/unpin a report, draft a message in a mid-list report, mark a report unread/read, and send a message. Verify each action syncs to Tab B without refreshing.
  3. In Tab A, import a really heavy Onyx state (Account > Troubleshoot > Import Onyx state). Verify Tab B adopts the imported state.
  4. Go to Account > Troubleshoot > Clear cache and restart. Verify Tab B is restored to the normal state as well.
  • Verify that no errors appear in the JS console

Offline tests

None — this PR only pins the Onyx dependency; cross-tab sync operates on local storage events and is unaffected by network state.

QA Steps

Same as Tests.

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari

Pins Onyx to callstack-internal/react-native-onyx#33dd460b (branch
eliran/94839-batch-collection-removals) to test the cross-tab sync fix for the
two-tabs heavy account crash.
@github-actions

Copy link
Copy Markdown
Contributor

⚠️ This PR is possibly changing native code and/or updating libraries, it may cause problems with HybridApp. Please check if any patch updates are required in the HybridApp repo and run an AdHoc build to verify that HybridApp will not break. Ask Contributor Plus for help if you are not sure how to handle this. ⚠️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant