Move pre-selected assignee to top of list in Issue New Expensify Card flow - #98131
Conversation
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
|
@linhvovan29546 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
@marufsharifi Can you please add a test? Thanks |
| textInputOptions={textInputOptions} | ||
| isLoadingNewOptions={canInviteMembers && !!isSearchingForReports} | ||
| initiallyFocusedItemKey={issueNewCard?.data?.assigneeEmail} | ||
| initiallyFocusedItemKey={initialAssigneeEmail} |
There was a problem hiding this comment.
I think we should add shouldScrollToFocusedIndexOnMount={false} as well.
|
@linhvovan29546 The feedbacks have been applied, thanks |
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppScreen.Recording.2026-08-30.at.09.33.15.movAndroid: mWeb ChromeScreen.Recording.2026-08-30.at.09.30.04.moviOS: HybridAppScreen.Recording.2026-08-30.at.09.33.53.moviOS: mWeb SafariScreen.Recording.2026-08-30.at.09.15.50.movMacOS: Chrome / SafariScreen.Recording.2026-08-30.at.09.10.01.mov |
|
@robertjchen, could you please ask someone else to take a look at this pr, since @heyjennahay seems to be ooo. thanks. |
|
I think this is fine to merge 👍 |
|
🚧 robertjchen has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
🚀 Deployed to staging by https://github.com/robertjchen in version: 9.4.69-0 🚀
|
|
🤖 No help site changes required — no draft PR created. This PR only changes the ordering of an existing list: on the "Who needs a card?" step, the already-selected member is pinned to the top when the step reopens. It adds no new feature, setting, button, or step, and it renames nothing. How I checkedWhat the PR changes — What the help site says about this flow — the only article documenting card issuance is Broader sweep — I grepped all of Since the linked issue Expensify/App#69184 is a UI-polish rollout across many pickers, future PRs in the same series will land in the same place: no documented behavior to update. @marufsharifi, please review the linked help site PR and confirm it reflects the current behavior. Then mark the linked help site PR Note: since no docs changes were needed, there is no linked help site PR to review. If you disagree and want an article to call out the pinning behavior, reply with |
|
🚀 Deployed to production by https://github.com/francoisl in version: 9.4.69-1 🚀
Bundle Size Analysis (Sentry): |
Explanation of Change
Part of the ongoing rollout to show pre-selected list items at the top when a selection list (re)opens. This applies the established pattern to the Issue New Expensify Card → "Who needs a card?" assignee step, mirroring the already-merged assign-card AssigneeStep.
Fixed Issues
$ #69184
PROPOSAL: #69184 (comment)
Tests
Offline tests
Same as tests
QA Steps
Same as tests
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Screen.Recording.2026-08-26.at.6.47.40.PM.mov
Android: mWeb Chrome
Screen_Recording_20260824_151543_Chrome.mp4
iOS: Native
Screen.Recording.2026-08-26.at.7.17.50.PM.mov
iOS: mWeb Safari
Screen.Recording.2026-08-24.at.5.14.14.PM.mov
MacOS: Chrome / Safari
Screen.Recording.2026-08-24.at.3.03.41.PM.mov