[Payment due @abdulrahuman5196] Send the view's expense columns when exporting a grouped current view - #98291
Conversation
|
@abdulrahuman5196 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
hey @abdulrahuman5196 please review this one when you have a chance. |
trjExpensify
left a comment
trjExpensify
left a comment
There was a problem hiding this comment.
Lovely, thanks for jumping on this. 👍
|
Hi, Will check on this. |
|
Checking now |
|
@codex review |
|
@rlinoz I am getting 404 for the images attached in the authors list? |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 03e05a00cd
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
can you try again please |
Works now, thanks. @rlinoz But I am not seeing rows of "First Approved", "First Approver" columns coming up in the csv, i assume that would be a backend fix? Also kindly respond to this as well - #98291 (comment) |
yes, some columns are not being processed in the backend, that will be a separate issue/pr. |
|
@abdulrahuman5196 this should be ready for you to finish the review/checklis 😄 |
|
Oh got it. Will close out in couple of hours |
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppAndroid: mWeb ChromeiOS: HybridAppiOS: mWeb Safari |
abdulrahuman5196
left a comment
abdulrahuman5196
left a comment
There was a problem hiding this comment.
Changes looks good and works well. Reviewers checklist is also complete.
All yours.
🎀 👀 🎀
C+ Reviewed
melvin-bot
Bot
changed the title
|
🎯 @abdulrahuman5196, thanks for reviewing and testing this PR! 🎉 A payment issue will be created for your review once this PR is deployed to production. If payment is not needed (e.g., regression PR review fix etc), react with 👎 to this comment to prevent the payment issue from being created. |
|
🚧 deetergp has triggered a test Expensify/App build. You can view the workflow run here. |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
6 participants
Explanation of Change
On a grouped Search — the Bank Reconciliation view, or any
groupBy:search — "Export current view" produced a CSV whose expense rows carried a fixed eight columns rather than the columns configured in the view, so adding From or Tag to the view did not add them to the export.This PR sends the necessary info so Auth exports
Fixed Issues
$ https://github.com/Expensify/Expensify/issues/669002
$ https://github.com/Expensify/Expensify/issues/668120
$ https://github.com/Expensify/Expensify/issues/652978
PROPOSAL: N/A — internal
Tests
Export basic export expense/reports
Export current view expense/reports
Export current view grouped expenses
Offline tests
An export is a network request and is unchanged here — only the parameters it carries differ. Offline, choosing "Current view" behaves exactly as it does on
main.QA Steps
Export basic export expense/reports
Go to the spend page > select a few expenses > X selected > export > basic export
Verify it has all the basic export columns
Go to the spend page > reports > select a few reports > X selected > export > basic export
Verify it has all the basic export columns
Export current view expense/reports
In the spend page > Display > Add a few more columns
Select a few expenses > X selected > export > current view
Verify it has all the selected columns
In the spend page > reports > Display > Add a few more columns
Select a few reports> X selected > export > current view
Verify it has all the selected columns
Export current view grouped expenses
Same as tests, steps 3 onward, on staging once the Auth and Web-Expensify changes are deployed.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
N/A — telemetry configuration change with no UI.
Android: mWeb Chrome
N/A — telemetry configuration change with no UI.
iOS: Native
N/A — telemetry configuration change with no UI.
iOS: mWeb Safari
N/A — telemetry configuration change with no UI.
MacOS: Chrome / Safari
N/A — telemetry configuration change with no UI.