Use allReportActionsList param instead of module-level getAllReportActions in updateSplitTransactions by MelvinBot · Pull Request #98301 · Expensify/App

MelvinBot · 2026-08-11T13:08:22Z

Explanation of Change

updateSplitTransactions (in SplitTransactionUpdate.ts) was calling the module-level getAllReportActions(reportID) helper in 6 places. That helper reads ReportActionsUtils' module-scoped allReportActions (its own Onyx.connect source), which is exactly the binding that surfaced in production as ReferenceError: getAllReportActions is not defined (Sentry APP-JWE / APP-JWD, inside a requestAnimationFrame callback).

updateSplitTransactions already receives the same collection as its allReportActionsList parameter — every caller sources it from useOnyx(ONYXKEYS.COLLECTION.REPORT_ACTIONS) — and the parameter form is already used elsewhere in the same function. This change replaces the 6 getAllReportActions(<id>) calls with the equivalent parameter lookup and drops the now-unused import:

allReportActionsList?.[`${ONYXKEYS.COLLECTION.REPORT_ACTIONS}${<id>}`] ?? {}

The trailing ?? {} preserves getAllReportActions' never-undefined contract for the Object.values(...) consumers. This is behavior-preserving in production (where the collection is always populated) and removes the module-level dependency that produced the crash.

Test updates: the split test suites previously passed allReportActionsList: undefined at several call sites and relied on the module-level function as the real data source. Those sites now pass the real REPORT_ACTIONS collection (matching production), so the affected split tests exercise the same data path the app does. Call sites that intentionally test the empty/absent case are left as-is. The full tests/actions/IOUTest/SplitTest.ts (125 tests) and SplitSelfDMTest.ts suites pass.

Fixed Issues

$ #98105
PROPOSAL: #98105 (comment)

Tests

Precondition: be on a workspace where the split-expense feature is available, and open the browser JS console (so you can watch for errors).

Submit an expense in a workspace chat (e.g. a manual expense with an amount).
Open the expense, tap the amount (or open the transaction thread) and choose Split expense.
Split the transaction into 2+ parts (e.g. split evenly) and save/confirm the split.
Verify the split completes and the resulting split expenses appear, with no red error screen and no ReferenceError: getAllReportActions is not defined (or any uncaught ReferenceError) in the JS console.
Edit the split again: open the split-expense overview, change one of the split amounts (or delete one part), and save.
Verify the update completes successfully and again no getAllReportActions is not defined error appears in the console.
Repeat once with a held split expense (put one split on hold, then edit the split) to exercise the hold-comment copy path, and confirm no console error appears.

Offline tests

Same as Tests. This is a behavior-preserving refactor that only changes where updateSplitTransactions reads report actions from (a parameter it already receives via useOnyx instead of a module-level helper), so offline behavior is unchanged: performing the split/edit while offline should optimistically update as before with no console error.

QA Steps

Same as Tests.

Verify that no errors appear in the JS console