Fix: "disabled submissions" system message thread header shows "turned Scheduled Submit off" - #98376
Conversation
…der shows "turned Scheduled Submit off"""
|
@Krishna2323 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
@stitesExpensify I can review if C+ review is required. |
|
hi @Krishna2323 a c+ review is required. Fixing the tests now. |
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppandroid_hybrid.mp4Android: mWeb Chromeandroid_mWeb.mp4iOS: HybridAppios_hybrid.mp4iOS: mWeb Safariios_mWeb.mp4MacOS: Chrome / Safariweb_chrome.mp4 |
|
@carlosmiceli Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
🚧 roryabraham has triggered a test Expensify/App build. You can view the workflow run here. |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
…bmission-frequency-changelog Fix: "disabled submissions" system message thread header shows "turned Scheduled Submit off" (cherry picked from commit 6e2d6b5) (cherry-picked to staging by roryabraham)
|
🚀 Cherry-picked to staging by https://github.com/roryabraham in version: 9.4.52-8 🚀
|
|
🤖 No help site changes required. This PR is an internal display fix: it makes the workspace system message for the auto-harvesting (submissions) toggle render the localized string — It does not add, rename, or change the behavior of any feature, workflow, setting, or button that users interact with — only the text of an automatically-generated system message. Help site articles (e.g. How to Set Up Automatic Report Submissions and Workspace Workflows) document how the submissions feature works, which is unchanged here, so no draft PR was created. |
Explanation of Change
Fixed Issues
$ #98202
$ https://github.com/Expensify/Expensify/issues/668650
PROPOSAL:
Tests
Offline tests
N/A
QA Steps
// TODO: These must be filled out, or the issue title must include "[No QA]."
Same as tests
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari