Skip to content

[NO QA] Drop browser extension errors from Sentry with denyUrls - #98417

Merged
Valforte merged 2 commits into
mainfrom
rodrigo-sentry-deny-extension-urls
Aug 12, 2026
Merged

[NO QA] Drop browser extension errors from Sentry with denyUrls#98417
Valforte merged 2 commits into
mainfrom
rodrigo-sentry-deny-extension-urls

Conversation

@rlinoz

@rlinoz rlinoz commented Aug 12, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Explanation of Change

Browser extensions inject code into every page NewDot runs on, and when that code throws, the SDK captures it as if it were ours. These events are unactionable — we cannot fix an extension — but they consume quota and pollute issue search.

Fixed Issues

$ https://expensify.slack.com/archives/C0A3FPPTGJY/p1786053533901599
PROPOSAL:

Tests

  • Verify that no errors appear in the JS console

Offline tests

QA Steps

NO QA, but this errors should disappear https://expensify.sentry.io/explore/errors/homepage/?dataset=errors&field=title&field=project&field=message&field=count%28%29&name=All%20Errors&query=&queryDataset=error-events&sort=-count&statsPeriod=7d&yAxis=count%28%29

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
      • If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
  • I verified that if a function's arguments changed that all usages have also been updated correctly
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

N/A — telemetry configuration change with no UI.

Android: mWeb Chrome

N/A — telemetry configuration change with no UI.

iOS: Native

N/A — telemetry configuration change with no UI.

iOS: mWeb Safari

N/A — telemetry configuration change with no UI.

MacOS: Chrome / Safari

N/A — telemetry configuration change with no UI.

@rlinoz
Drop browser extension errors from Sentry with denyUrls
f809212 
Errors thrown inside chrome-extension://, moz-extension://, safari-extension://
and safari-web-extension:// code are not ours to act on. Sentry's server-side
browser-extension inbound filter cannot catch them because the React Native SDK
rewrites every frame filename to app:///... before sending. denyUrls is evaluated
client-side by inboundFilters, which the SDK registers ahead of rewriteFrames, so
it still sees the original scheme.
@rlinoz rlinoz changed the title Drop browser extension errors from Sentry with denyUrls [NO QA] Drop browser extension errors from Sentry with denyUrls Aug 12, 2026
@rlinoz
rlinoz marked this pull request as ready for review August 12, 2026 12:22
@rlinoz
rlinoz requested review from a team as code owners August 12, 2026 12:22
@melvin-bot
melvin-bot Bot requested review from JmillsExpensify and Valforte and removed request for a team August 12, 2026 12:22
@melvin-bot

melvin-bot Bot commented Aug 12, 2026

Copy link
Copy Markdown

@Valforte Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@codecov

codecov Bot commented Aug 12, 2026 •
edited by github-actions Bot
Loading

Copy link
Copy Markdown

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines Coverage Δ
src/setup/telemetry/setupSentry.ts 0.00% <0.00%> (ø)
... and 8 files with indirect coverage changes

@rlinoz
rlinoz marked this pull request as draft August 12, 2026 12:27
@rlinoz
rlinoz marked this pull request as ready for review August 12, 2026 12:35
@rlinoz
rlinoz marked this pull request as draft August 12, 2026 12:59
@rlinoz
rlinoz marked this pull request as ready for review August 12, 2026 13:36
@Valforte

Valforte commented Aug 12, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Reviewer Checklist

  • I have verified the author checklist is complete (all boxes are checked off).
  • I verified the correct issue is linked in the ### Fixed Issues section above
  • I verified testing steps are clear and they cover the changes made in this PR
    • I verified the steps for local testing are in the Tests section
    • I verified the steps for Staging and/or Production testing are in the QA steps section
    • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I checked that screenshots or videos are included for tests on all platforms
  • I included screenshots or videos for tests on all platforms
  • I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
  • I verified tests pass on all platforms & I tested again on:
    • Android: HybridApp
    • Android: mWeb Chrome
    • iOS: HybridApp
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
  • I verified proper code patterns were followed (see Reviewing the code)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I verified that this PR follows the guidelines as stated in the Review Guidelines
  • I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
  • If a new component is created I verified that:
    • A similar component doesn't exist in the codebase
    • All props are defined accurately
    • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
    • The only data being stored in the state is data necessary for rendering and nothing else
    • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
  • I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp
Android: mWeb Chrome
iOS: HybridApp
iOS: mWeb Safari
MacOS: Chrome / Safari

@Valforte
Valforte merged commit c158c5d into main Aug 12, 2026
61 of 62 checks passed
@Valforte
Valforte deleted the rodrigo-sentry-deny-extension-urls branch August 12, 2026 14:58
@OSBotify

OSBotify commented Aug 12, 2026

Copy link
Copy Markdown
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@github-actions

github-actions Bot commented Aug 12, 2026

Copy link
Copy Markdown
Contributor

🚧 Valforte has triggered a test Expensify/App build. You can view the workflow run here.

@github-actions

github-actions Bot commented Aug 12, 2026

Copy link
Copy Markdown
Contributor

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #98417.

Android 🤖 iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-c158c5d-c5ac172-584ea73c9fab8f97403496579466551533ece84d/index.html https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-c158c5d-c5ac172-366fe7730f8caaa4cf6b24158bcdf82be24e94f6/index.html
Android iOS
Web 🕸️
https://98417.pr-testing.expensify.com
Web

👀 View the workflow run that generated this build 👀

@OSBotify OSBotify mentioned this pull request Aug 12, 2026
Open
@OSBotify

OSBotify commented Aug 12, 2026

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/Valforte in version: 9.4.53-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@MelvinBot

MelvinBot commented Aug 12, 2026

Copy link
Copy Markdown
Contributor

🤖 No help site changes required.

This PR is an internal telemetry configuration change — it adds denyUrls to the Sentry setup in src/setup/telemetry/setupSentry.ts so that errors thrown by browser extensions are dropped before reaching Sentry.

There is no user-facing behavior, UI, feature, setting, or workflow change here — nothing a customer would see or do differently. The help site articles under App/docs/articles document customer-facing product features (Expensify Classic, New Expensify, Travel), and none of them reference Sentry, telemetry, or error reporting. So there's nothing to update, and I have not created a draft docs PR.

If you believe this change does have a customer-facing angle I've missed, let me know and I'll take another look.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Valforte Valforte Valforte approved these changes
@JmillsExpensify JmillsExpensify Awaiting requested review from JmillsExpensify

Assignees

@rlinoz rlinoz

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@rlinoz @Valforte @OSBotify @MelvinBot