[No QA] Docs updates for E/A#96169 alternate route selection for distance expenses - #98472
Conversation
Co-authored-by: Gabriel Cyganek <GCyganek@users.noreply.github.com>
|
The only failing check is Check independent approval, and there's no code fix to push for it. That check isn't testing this PR's code — it fails because the PR doesn't yet have enough independent Expensify employee approvals (job log shows Every actual CI check is green — Next step: this needs a reviewer's approval, not a code change. @GCyganek once you've reviewed the doc changes, request/assign a reviewer to approve — that will resolve the check. |
|
A preview of your ExpensifyHelp changes have been deployed to https://50079f19.helpdot.pages.dev ⚡️ Updated articles: |
HelpDot Documentation ReviewOverall AssessmentThis PR updates the Distance Expenses article to document the new alternate route selection for map-based Distance expenses. The changes are well-scoped to a single existing workflow: a step added to the create flow, a note added to the edit flow, and a new FAQ entry. The additions read naturally, use exact UI terminology, and integrate cleanly into the existing structure. No heading-hierarchy or metadata violations are introduced. Scores Summary
Key Findings
Recommendations
Files Reviewed
Note: Detailed line-by-line feedback has been provided as inline comments. |
Concierge reviewer checklist:
For more detailed instructions on completing this checklist, see How do I review a HelpDot PR as a Concierge Team member? |
|
@johncschuster Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
🚀 Deployed to staging by https://github.com/johncschuster in version: 9.4.69-0 🚀
|
|
🚀 Deployed to production by https://github.com/francoisl in version: 9.4.69-1 🚀
Bundle Size Analysis (Sentry): |
Explanation of Change
#96169 adds alternate route selection for map-based Distance expenses: when a start and stop location have more than one driving route, the map now draws both and lets you tap one to choose it. The chosen route's distance and amount are used, and the selection is preserved when editing an existing expense.
This PR updates the Distance Expenses help article to document this behavior:
keywordsmetadata to include route-selection search phrases.Notes on verification
The PR adds no new user-facing copy strings (no
src/languages/*.tschanges), so the interaction is purely visual — tap a route on the map to select it. All button and tab labels referenced (Map, Manual, Next, Create expense, Save) are unchanged and already present in the article. I could not drive the live UI to capture a screenshot of the two-route map in this run, so the behavioral descriptions are drawn from the PR's own explanation and test steps — please double-check them against the current UI.Related PR
@GCyganek, please review the files changed and confirm they reflect the current behavior. Then post a new comment saying
@MelvinBot mark this PR as ready for review.