[No QA] Docs updates for E/A#97883 Document Send to someone for tracked expenses - #99130
Conversation
Co-authored-by: Shawn Borton <shawnborton@users.noreply.github.com>
This comment has been minimized.
This comment has been minimized.
|
Seems good to me 👍 |
Concierge reviewer checklist:
For more detailed instructions on completing this checklist, see How do I review a HelpDot PR as a Concierge Team member? |
|
@VictoriaExpensify Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
|
||
| --- | ||
|
|
||
| ## How to send a tracked expense to someone |
There was a problem hiding this comment.
AI readiness (feature naming): The heading is task-based (good), but instructional headings should surface the exact UI feature label for retrieval (HELP_AUTHORING_GUIDELINES.md Section 6; TEMPLATE.md heading guidance). The UI option is Send to someone, so consider referencing it, e.g. ## How to use Send to someone for a tracked expense.
HelpDot Documentation ReviewOverall AssessmentThis PR adds a new task-based section, Scores Summary
Key Findings
Recommendations
Files Reviewed
Note: Detailed line-by-line feedback has been provided as inline comments. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 52d6f65a50
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
|
A preview of your ExpensifyHelp changes have been deployed to https://5834256d.helpdot.pages.dev ⚡️ Updated articles: |
|
🚀 Deployed to staging by https://github.com/VictoriaExpensify in version: 9.4.69-0 🚀
|
|
🚀 Deployed to production by https://github.com/francoisl in version: 9.4.69-1 🚀
Bundle Size Analysis (Sentry): |
Explanation of Change
This PR updates the Track Expenses help article to document the new Send to someone option added to a tracked expense's More menu in Expensify/App#97883.
Previously the article only described submitting a tracked expense via the Concierge actionable message in the Expense Chat, plus the click-into options available to workspace members. The merged change adds a Send to someone row at the top of the More menu when viewing an unreported tracked expense in Spend > Expenses, giving users a direct path to submit it to a recipient (no workspace required). This PR adds a
## How to send a tracked expense to someonesection covering that flow and extends the frontmatter keywords for retrieval. Bug 1 in the source PR (where a "Something else" user lands after creating an expense) is internal navigation behavior and doesn't change any documented workflow, so no doc update was needed for it.Applied
docs/HELPSITE_NAMING_CONVENTIONS.md,docs/HELP_AUTHORING_GUIDELINES.md, anddocs/TEMPLATE.md. UI labels (Spend > Expenses, More, Send to someone) were verified against the source translation strings insrc/languages/en.ts(common.more= "More",iou.sendToSomeone= "Send to someone"). Live-UI verification could not be completed this run because the dev web app was stuck on the boot splash and sign-in was unavailable — please confirm the labels/flow against the current UI when reviewing.Fixed Issues
$ #97883
PROPOSAL:
Tests
// TODO: The human co-author must fill out the tests you ran before marking this PR as "ready for review".
// Please describe what tests you performed that validate your changes worked.
Offline tests
QA Steps
// TODO: The human co-author must fill out the QA tests before marking this PR as "ready for review", or the issue title must include "[No QA]."
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
@shawnborton, please review the files changed and confirm they reflect the current behavior. Then post a new comment saying
@MelvinBot mark this PR as ready for review.