Skip to content

[No QA] Docs updates for E/A#97883 Document Send to someone for tracked expenses - #99130

Merged
VictoriaExpensify merged 2 commits into
mainfrom
claude-docs-sendToSomeoneTrackedExpense
Sep 2, 2026
Merged

[No QA] Docs updates for E/A#97883 Document Send to someone for tracked expenses#99130
VictoriaExpensify merged 2 commits into
mainfrom
claude-docs-sendToSomeoneTrackedExpense

Conversation

@MelvinBot

Copy link
Copy Markdown
Contributor

Explanation of Change

This PR updates the Track Expenses help article to document the new Send to someone option added to a tracked expense's More menu in Expensify/App#97883.

Previously the article only described submitting a tracked expense via the Concierge actionable message in the Expense Chat, plus the click-into options available to workspace members. The merged change adds a Send to someone row at the top of the More menu when viewing an unreported tracked expense in Spend > Expenses, giving users a direct path to submit it to a recipient (no workspace required). This PR adds a ## How to send a tracked expense to someone section covering that flow and extends the frontmatter keywords for retrieval. Bug 1 in the source PR (where a "Something else" user lands after creating an expense) is internal navigation behavior and doesn't change any documented workflow, so no doc update was needed for it.

Applied docs/HELPSITE_NAMING_CONVENTIONS.md, docs/HELP_AUTHORING_GUIDELINES.md, and docs/TEMPLATE.md. UI labels (Spend > Expenses, More, Send to someone) were verified against the source translation strings in src/languages/en.ts (common.more = "More", iou.sendToSomeone = "Send to someone"). Live-UI verification could not be completed this run because the dev web app was stuck on the boot splash and sign-in was unavailable — please confirm the labels/flow against the current UI when reviewing.

Fixed Issues

$ #97883
PROPOSAL:

Tests

// TODO: The human co-author must fill out the tests you ran before marking this PR as "ready for review".
// Please describe what tests you performed that validate your changes worked.

  • Verify that no errors appear in the JS console

Offline tests

QA Steps

// TODO: The human co-author must fill out the QA tests before marking this PR as "ready for review", or the issue title must include "[No QA]."

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari

@shawnborton, please review the files changed and confirm they reflect the current behavior. Then post a new comment saying @MelvinBot mark this PR as ready for review.

Co-authored-by: Shawn Borton <shawnborton@users.noreply.github.com>
@MelvinBot
MelvinBot requested a review from a team August 21, 2026 01:22
@MelvinBot MelvinBot added the HelpDot Apply this label if the issue relates to ExpensifyHelp label Aug 21, 2026
@github-actions github-actions Bot changed the title Docs updates for E/A#97883 Document Send to someone for tracked expenses [No QA] Docs updates for E/A#97883 Document Send to someone for tracked expenses Aug 21, 2026
@OSBotify

This comment has been minimized.

@shawnborton

Copy link
Copy Markdown
Contributor

Seems good to me 👍

@stephanieelliott
stephanieelliott marked this pull request as ready for review August 28, 2026 03:49
@stephanieelliott
stephanieelliott self-requested a review as a code owner August 28, 2026 03:49
@melvin-bot

melvin-bot Bot commented Aug 28, 2026

Copy link
Copy Markdown

Concierge reviewer checklist:

  • I have verified the accuracy of the article
    • The article is within a hub that makes sense, and the navigation is correct
    • All processes, screenshots, and examples align with current product behavior.
    • All links within the doc have been verified for correct destination and functionality.
  • I have verified the readability of the article
    • The article's language is clear, concise, and free of jargon.
    • The grammar, spelling, and punctuation are correct.
    • The article contains at least one image, or that an image is not necessary
  • I have verified the formatting of the article
    • The article has consistent formatting (headings, bullet points, etc.) with other HelpDot articles and that aligns with the HelpDot formatting standards.
    • The article has proper text spacing and breaks for readability.
  • I have verified the article has the appropriate tone and style
    • The article's tone is professional, friendly, and suitable for the target audience.
    • The article's tone, terminology, and voice are consistent throughout.
  • I have verified the overall quality of the article
    • The article is not missing any information, nor does it contain redundant information.
    • The article fully addresses user needs.
  • I have verified that all requested improvements have been addressed

For more detailed instructions on completing this checklist, see How do I review a HelpDot PR as a Concierge Team member?

cc @VictoriaExpensify

@melvin-bot
melvin-bot Bot requested review from VictoriaExpensify and removed request for a team August 28, 2026 03:49
@melvin-bot

melvin-bot Bot commented Aug 28, 2026

Copy link
Copy Markdown

@VictoriaExpensify Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

Comment thread docs/articles/new-expensify/reports-and-expenses/Track-Expenses.md Outdated

---

## How to send a tracked expense to someone

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AI readiness (feature naming): The heading is task-based (good), but instructional headings should surface the exact UI feature label for retrieval (HELP_AUTHORING_GUIDELINES.md Section 6; TEMPLATE.md heading guidance). The UI option is Send to someone, so consider referencing it, e.g. ## How to use Send to someone for a tracked expense.

@github-actions

Copy link
Copy Markdown
Contributor

HelpDot Documentation Review

Overall Assessment

This PR adds a new task-based section, ## How to send a tracked expense to someone, to the Track Expenses article, plus two new keyword phrases (send to someone, submit tracked expense). The addition is concise, procedural, and well-formatted. It aligns with the surrounding article and follows most governance rules. The main opportunities relate to slight redundancy with the existing "What you can do with tracked expenses" section and a minor navigation-phrasing nuance.

Scores Summary

  • Readability: 9/10 - Clear, scannable, action-oriented sequential steps with a helpful clarifying note about when the option appears.
  • AI Readiness: 8/10 - Task-based "How to..." heading, full feature terminology, and search-aligned keywords. Slightly capped because the change touches only keywords and leaves the article's missing internalScope metadata unaddressed (pre-existing, outside the diff, so not penalized further).
  • Style Compliance: 8/10 - Button/menu labels (More, Send to someone) are correctly bolded in Sentence case and match terminology used elsewhere in the article. Minor: "Open the More menu" and "Go to Spend > Expenses" follow the article's established pattern but are lighter than the strict web/mobile navigation split in HELPSITE_NAMING_CONVENTIONS.md.

Key Findings

  • Positive: New heading is task-based and starts with "How to," satisfying Heading Rules (Section 2) and AI Retrieval Optimization (Section 6).
  • Positive: UI labels are exact, bolded, and consistent with the rest of the file (Spend > Expenses, More, Send to someone).
  • Positive: The note explaining that Send to someone only appears while the expense is still tracked prevents a likely support question, showing strong deterministic writing.
  • Minor: Content overlaps with the existing "What you can do with tracked expenses" section (lines 81-83), which already documents the Send to someone option. Consider consolidating to avoid duplicate coverage of the same workflow.
  • Minor: Navigation phrasing does not specify web vs. mobile per the Navigation Instruction Standards; the SmartScan/manual sections in this article use explicit "On mobile/On desktop" blocks, so the new section is slightly less rigorous by comparison.

Recommendations

  • Consolidate or cross-reference the new section with the existing "What you can do with tracked expenses" content so the Send to someone workflow is documented once.
  • Optionally note whether the flow differs on mobile vs. desktop to match the navigation rigor used elsewhere in this article.
  • Consider adding internalScope to the frontmatter (Section 3 metadata requirement) while this file is being touched, since it is currently absent.

Files Reviewed

  • docs/articles/new-expensify/reports-and-expenses/Track-Expenses.md - Approve with minor suggestions; new section is compliant and well-written, with light redundancy to address.

Note: Detailed line-by-line feedback has been provided as inline comments.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 52d6f65a50

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment thread docs/articles/new-expensify/reports-and-expenses/Track-Expenses.md
Comment thread docs/articles/new-expensify/reports-and-expenses/Track-Expenses.md Outdated
@OSBotify

Copy link
Copy Markdown
Contributor

A preview of your ExpensifyHelp changes have been deployed to https://5834256d.helpdot.pages.dev ⚡️

Updated articles:

@VictoriaExpensify
VictoriaExpensify merged commit ce46db0 into main Sep 2, 2026
16 of 17 checks passed
@VictoriaExpensify
VictoriaExpensify deleted the claude-docs-sendToSomeoneTrackedExpense branch September 2, 2026 10:49
@OSBotify

OSBotify commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/VictoriaExpensify in version: 9.4.69-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@OSBotify

OSBotify commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/francoisl in version: 9.4.69-1 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Bundle Size Analysis (Sentry):

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

HelpDot Apply this label if the issue relates to ExpensifyHelp

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants