Add link to home address message - #99767
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4ab4b732a4
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| return ( | ||
| <ReportActionItemBasicMessage message={getReportActionText(action)}> | ||
| <ReportActionItemBasicMessage> | ||
| <RenderHTML html={`<comment><muted-text>${getReportActionHtml(action)}</muted-text></comment>`} /> |
There was a problem hiding this comment.
Preserve the text fallback when HTML is absent
When a HOMEADDRESSREQUIRED action comes from an older or cached response containing only the required message.text field, this now renders an empty message because message.html is optional and getReportActionHtml() returns ''. The previous getReportActionText() path explicitly fell back to message.text, so retain that fallback while using HTML when available.
Useful? React with 👍 / 👎.
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
|
ESLint failed on files I did not modify. Asked about this here https://expensify.slack.com/archives/C01GTK53T8Q/p1787933503311759 but let's not block on that |
|
Looks like the backend PRs aren't deployed yet, didn't get the message. |
|
TypeScript errors are unrelated to the changes here, let's ignore them. Opened a thread https://expensify.slack.com/archives/C01GTK53T8Q/p1788207872549709 |
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppAndroid: mWeb ChromeiOS: HybridAppiOS: mWeb SafariMacOS: Chrome / Safari |
|
Bump! |
|
@Gonals all yours |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by https://github.com/Gonals in version: 9.4.69-0 🚀
|
|
🤖 Help site review: no changes required. This PR is a rendering-only fix. Nothing user-facing changed in the way a help article would describe it: no new feature, no renamed setting, no new tab, button, or flow. The Add home address button that sits below the message already existed and still behaves the same — the link just gives users a second way to reach the same page. Docs I checked
Since no existing article describes this message or the home address prompt, there is no text to correct. Writing a brand-new article about it would go beyond documenting this PR's change. I did not open a draft PR, since there is nothing to change. @iwiznia, please review the linked help site PR and confirm it reflects the current behavior. Then mark the linked help site PR |
|
🚧 Gonals has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
Deploy Blocker #100279 was identified to be related to this PR. |
|
🚀 Deployed to production by https://github.com/francoisl in version: 9.4.69-1 🚀
Bundle Size Analysis (Sentry): |

Explanation of Change
Fixed Issues
$#99740
PROPOSAL:
Tests
This https://github.com/Expensify/Web-Expensify/pull/55736 and https://github.com/Expensify/Auth/pull/24093 need to be deployed for this to work, so if you are QAing one of these PRs, skip the QA if all are not deployed.
Pre-condition: user B Gmail invalidated account login in one window, Expensifail account in another window
Offline tests
No
QA Steps
// TODO: These must be filled out, or the issue title must include "[No QA]."
Same as tests
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari