Skip to content

Add link to home address message - #99767

Merged
Gonals merged 10 commits into
mainfrom
ionatan_linkhomeaddress
Sep 2, 2026
Merged

Add link to home address message#99767
Gonals merged 10 commits into
mainfrom
ionatan_linkhomeaddress

Conversation

@iwiznia

@iwiznia iwiznia commented Aug 28, 2026

Copy link
Copy Markdown
Contributor

Explanation of Change

Fixed Issues

$#99740
PROPOSAL:

Tests

This https://github.com/Expensify/Web-Expensify/pull/55736 and https://github.com/Expensify/Auth/pull/24093 need to be deployed for this to work, so if you are QAing one of these PRs, skip the QA if all are not deployed.

Pre-condition: user B Gmail invalidated account login in one window, Expensifail account in another window

  1. Launch app
  2. Login Expensifail account
  3. Create workspace with address
  4. Enable distance rate and from settings - exclude commutes select office and home location
  5. Invite a member ( user B)
  6. Check in user B account - workspace chat
  7. Check home address is linked and takes you to add the address, same as the button
image

Offline tests

No

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."

Same as tests

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari

@iwiznia iwiznia self-assigned this Aug 28, 2026
@iwiznia
iwiznia marked this pull request as ready for review August 28, 2026 14:59
@iwiznia
iwiznia requested review from a team as code owners August 28, 2026 14:59
@melvin-bot
melvin-bot Bot requested review from getusha and removed request for a team August 28, 2026 14:59
@melvin-bot

melvin-bot Bot commented Aug 28, 2026

Copy link
Copy Markdown

@getusha Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot
melvin-bot Bot requested review from flaviadefaria and removed request for a team August 28, 2026 14:59

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 4ab4b732a4

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

return (
<ReportActionItemBasicMessage message={getReportActionText(action)}>
<ReportActionItemBasicMessage>
<RenderHTML html={`<comment><muted-text>${getReportActionHtml(action)}</muted-text></comment>`} />

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Preserve the text fallback when HTML is absent

When a HOMEADDRESSREQUIRED action comes from an older or cached response containing only the required message.text field, this now renders an empty message because message.html is optional and getReportActionHtml() returns ''. The previous getReportActionText() path explicitly fell back to message.text, so retain that fallback while using HTML when available.

Useful? React with 👍 / 👎.

@iwiznia
iwiznia requested a review from Gonals August 28, 2026 15:28
@codecov

codecov Bot commented Aug 28, 2026

Copy link
Copy Markdown

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines Coverage Δ
...port/actionContents/HomeAddressRequiredContent.tsx 100.00% <100.00%> (ø)
... and 17 files with indirect coverage changes

@iwiznia

iwiznia commented Aug 28, 2026

Copy link
Copy Markdown
Contributor Author

ESLint failed on files I did not modify. Asked about this here https://expensify.slack.com/archives/C01GTK53T8Q/p1787933503311759 but let's not block on that

@getusha

getusha commented Aug 29, 2026

Copy link
Copy Markdown
Contributor

Looks like the backend PRs aren't deployed yet, didn't get the message.

@iwiznia

iwiznia commented Aug 31, 2026

Copy link
Copy Markdown
Contributor Author

Updated. BTW we don't need to block on the backend PRs.
Please review @getusha @Gonals

@iwiznia

iwiznia commented Aug 31, 2026

Copy link
Copy Markdown
Contributor Author

TypeScript errors are unrelated to the changes here, let's ignore them. Opened a thread https://expensify.slack.com/archives/C01GTK53T8Q/p1788207872549709

@getusha

getusha commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

Reviewer Checklist

  • I have verified the author checklist is complete (all boxes are checked off).
  • I verified the correct issue is linked in the ### Fixed Issues section above
  • I verified testing steps are clear and they cover the changes made in this PR
    • I verified the steps for local testing are in the Tests section
    • I verified the steps for Staging and/or Production testing are in the QA steps section
    • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I checked that screenshots or videos are included for tests on all platforms
  • I included screenshots or videos for tests on all platforms
  • I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
  • I verified tests pass on all platforms & I tested again on:
    • Android: HybridApp
    • Android: mWeb Chrome
    • iOS: HybridApp
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
  • I verified proper code patterns were followed (see Reviewing the code)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I verified that this PR follows the guidelines as stated in the Review Guidelines
  • I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
  • If a new component is created I verified that:
    • A similar component doesn't exist in the codebase
    • All props are defined accurately
    • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
    • The only data being stored in the state is data necessary for rendering and nothing else
    • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
  • I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp
Android: mWeb Chrome
iOS: HybridApp
iOS: mWeb Safari
MacOS: Chrome / Safari

@iwiznia

iwiznia commented Sep 2, 2026

Copy link
Copy Markdown
Contributor Author

Bump!

@getusha

getusha commented Sep 2, 2026

Copy link
Copy Markdown
Contributor
Screenshot 2026-09-02 at 6 09 35 in the evening skipping testing since can't see it on web

@getusha getusha left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@iwiznia

iwiznia commented Sep 2, 2026

Copy link
Copy Markdown
Contributor Author

@Gonals all yours

@Gonals
Gonals merged commit 6a02681 into main Sep 2, 2026
43 of 45 checks passed
@Gonals
Gonals deleted the ionatan_linkhomeaddress branch September 2, 2026 21:28
@OSBotify

OSBotify commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify

OSBotify commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/Gonals in version: 9.4.69-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@MelvinBot

Copy link
Copy Markdown
Contributor

🤖 Help site review: no changes required.

This PR is a rendering-only fix. HomeAddressRequiredContent.tsx now passes the report action's HTML through RenderHTML instead of rendering plain text, so "home address" in the system message shows as a link. The remaining two files are unit tests.

Nothing user-facing changed in the way a help article would describe it: no new feature, no renamed setting, no new tab, button, or flow. The Add home address button that sits below the message already existed and still behaves the same — the link just gives users a second way to reach the same page.

Docs I checked
  • grep -ril "home address" across docs/articles → only articles/new-expensify/wallet-and-payments/Connect-a-Business-Bank-Account.md, which covers a business bank account's address fields, not this message.
  • grep -ril "commut" → only articles/expensify-classic/workspaces/Expense-Settings.md, and it doesn't mention commute exclusion or home address.
  • articles/new-expensify/workspaces/Set-distance-rates.md and articles/new-expensify/reports-and-expenses/Distance-Expenses.md don't document the exclude-commutes home address requirement at all.

Since no existing article describes this message or the home address prompt, there is no text to correct. Writing a brand-new article about it would go beyond documenting this PR's change.

I did not open a draft PR, since there is nothing to change.

@iwiznia, please review the linked help site PR and confirm it reflects the current behavior. Then mark the linked help site PR Ready for review


view run

@mitarachim

mitarachim commented Sep 2, 2026

Copy link
Copy Markdown

Deploy Blocker #100235 was identified to be related to this PR.
I can’t verify if the issue reproduces in this PR because there’s no ad hoc build for it. but this issue not reproduce in previous PR
Could you please double check if it's not introduced by #99767

@github-actions

github-actions Bot commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

🚧 Gonals has triggered a test Expensify/App build. You can view the workflow run here.

@jponikarchuk

Copy link
Copy Markdown

Deploy Blocker #100279 was identified to be related to this PR.

@OSBotify

OSBotify commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/francoisl in version: 9.4.69-1 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Bundle Size Analysis (Sentry):

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants