Skip to content

[NO QA] Fix currency helper references in BulkEdit tests - #99952

Merged
blimpich merged 3 commits into
mainfrom
codex/fix-bulk-edit-currency-helper-references
Aug 31, 2026
Merged

[NO QA] Fix currency helper references in BulkEdit tests#99952
blimpich merged 3 commits into
mainfrom
codex/fix-bulk-edit-currency-helper-references

Conversation

@blimpich

@blimpich blimpich commented Aug 31, 2026

Copy link
Copy Markdown
Contributor

Fixes the CI failures reported in:

The three original failures shared one cause: BulkEditTest.ts had three missed references after migrating from production currency helpers to test helpers. Those call sites now use getCurrencyDecimalsLocal and getCurrencySymbolLocal.

The PR also fixes three unrelated TypeScript errors already present on main:

  • Replace the stale @components/Avatar import with AvatarFromIcon, preserving user/workspace avatar rendering.
  • Add the missed currentUserAccountID argument after shouldShowViolation changed signatures.
  • Remove the stale isPolicyExpenseChatEnabled field from a test fixture after it was removed from the Policy type.

Validation: TypeScript CI passes; focused Jest tests, ESLint, spelling, and React Compiler checks pass.

@codecov

codecov Bot commented Aug 31, 2026

Copy link
Copy Markdown

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines Coverage Δ
...derWithBackButtonComposed/HeaderWithBackButton.tsx 0.00% <ø> (ø)
src/libs/TransactionUtils/index.ts 92.03% <100.00%> (+0.07%) ⬆️
... and 10 files with indirect coverage changes

@blimpich
blimpich marked this pull request as ready for review August 31, 2026 19:09
@blimpich
blimpich requested review from a team as code owners August 31, 2026 19:09
@melvin-bot
melvin-bot Bot requested review from heyjennahay and marcochavezf and removed request for a team August 31, 2026 19:10
@melvin-bot

melvin-bot Bot commented Aug 31, 2026

Copy link
Copy Markdown

@marcochavezf Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot
melvin-bot Bot removed the request for review from a team August 31, 2026 19:10
@blimpich
blimpich removed the request for review from heyjennahay August 31, 2026 19:11

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 87fa57d17c

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment thread src/components/HeaderWithBackButtonComposed/HeaderWithBackButton.tsx Outdated
@blimpich
blimpich marked this pull request as draft August 31, 2026 19:20
@blimpich
blimpich marked this pull request as ready for review August 31, 2026 19:20
@blimpich
blimpich merged commit 017e69c into main Aug 31, 2026
46 of 49 checks passed
@blimpich
blimpich deleted the codex/fix-bulk-edit-currency-helper-references branch August 31, 2026 19:42
@github-actions

Copy link
Copy Markdown
Contributor

🚧 blimpich has triggered a test Expensify/App build. You can view the workflow run here.

@OSBotify

Copy link
Copy Markdown
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify

OSBotify commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/blimpich in version: 9.4.66-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@MelvinBot

Copy link
Copy Markdown
Contributor

🤖 No help site changes are required. I did not create a docs PR.

Every change in this PR is a build/type fix with no user-facing behavior change, so nothing in docs/articles goes stale.

Why each change is docs-neutral
Change Docs impact
src/components/HeaderWithBackButtonComposed/HeaderWithBackButton.tsx — swaps Avatar for AvatarFromIcon and passes the whole policyAvatar object instead of destructured props None. The workspace avatar renders the same; no label, setting, or flow changes.
src/libs/TransactionUtils/index.ts — adds the missing currentUserAccountID argument to shouldShowViolation None. Fixes a call site after the function signature changed. No change to which violations users see.
tests/actions/IOUTest/BulkEditTest.ts — uses getCurrencyDecimalsLocal / getCurrencySymbolLocal Test-only.
tests/unit/ReportUtilsTest.ts — drops the removed isPolicyExpenseChatEnabled fixture field Test-only.

No feature was added, removed, renamed, or moved, so there is no help site article to update.

@blimpich, since no docs changes were needed, there's no help site PR to review or mark Ready for review. Let me know if you'd rather I document something here anyway.


view run

@kavimuru

kavimuru commented Sep 2, 2026

Copy link
Copy Markdown

@blimpich what should be tested for the QA team?

@blimpich blimpich changed the title Fix currency helper references in BulkEdit tests [NO QA] Fix currency helper references in BulkEdit tests Sep 2, 2026
@blimpich

blimpich commented Sep 2, 2026

Copy link
Copy Markdown
Contributor Author

@kavimuru apologies this should be NO QA

@OSBotify

OSBotify commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/blimpich in version: 9.4.68-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 cancelled 🔪

@MelvinBot

Copy link
Copy Markdown
Contributor

🤖 No help site changes are required for this PR. I did not create a docs PR.

Why: This is a [NO QA] CI/TypeScript fix. Nothing user-facing changed — no new feature, no new setting, and no renamed tab, menu, or button that an article under docs/articles would describe.

Review of each changed file
File Change Docs impact
src/components/HeaderWithBackButtonComposed/HeaderWithBackButton.tsx Swapped the stale @components/Avatar import for AvatarFromIcon and passed the icon through directly None — the workspace avatar renders the same as before
src/libs/TransactionUtils/index.ts Added the missing currentUserAccountID argument to shouldShowViolation after its signature changed None — restores the intended argument order; no documented behavior changes
tests/actions/IOUTest/BulkEditTest.ts Three call sites now use getCurrencyDecimalsLocal / getCurrencySymbolLocal None — test-only
tests/unit/ReportUtilsTest.ts Removed the stale isPolicyExpenseChatEnabled fixture field None — test-only

I also checked the help site for articles that describe violations, workspace rules, and bulk editing expenses. None of them document the internals these changes touch, so none need updating.

@blimpich, please review the linked help site PR and confirm it reflects the current behavior. Then mark the linked help site PR Ready for review


view run

@OSBotify

OSBotify commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/francoisl in version: 9.4.68-1 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Bundle Size Analysis (Sentry):

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants