[NO QA] Fix currency helper references in BulkEdit tests - #99952
Conversation
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
|
@marcochavezf Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 87fa57d17c
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
|
🚧 blimpich has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by https://github.com/blimpich in version: 9.4.66-0 🚀
|
|
🤖 No help site changes are required. I did not create a docs PR. Every change in this PR is a build/type fix with no user-facing behavior change, so nothing in Why each change is docs-neutral
No feature was added, removed, renamed, or moved, so there is no help site article to update. @blimpich, since no docs changes were needed, there's no help site PR to review or mark |
|
@blimpich what should be tested for the QA team? |
|
@kavimuru apologies this should be NO QA |
|
🚀 Deployed to staging by https://github.com/blimpich in version: 9.4.68-0 🚀
|
|
🤖 No help site changes are required for this PR. I did not create a docs PR. Why: This is a Review of each changed file
I also checked the help site for articles that describe violations, workspace rules, and bulk editing expenses. None of them document the internals these changes touch, so none need updating. @blimpich, please review the linked help site PR and confirm it reflects the current behavior. Then mark the linked help site PR |
|
🚀 Deployed to production by https://github.com/francoisl in version: 9.4.68-1 🚀
Bundle Size Analysis (Sentry): |
Fixes the CI failures reported in:
The three original failures shared one cause: BulkEditTest.ts had three missed references after migrating from production currency helpers to test helpers. Those call sites now use getCurrencyDecimalsLocal and getCurrencySymbolLocal.
The PR also fixes three unrelated TypeScript errors already present on main:
Validation: TypeScript CI passes; focused Jest tests, ESLint, spelling, and React Compiler checks pass.