Skip to content

Ignore peer review check and show pending status for running checks - #367

Merged
NicolasBonet merged 5 commits into
mainfrom
nicolas-checkrun-status-fixes
Aug 6, 2026
Merged

Ignore peer review check and show pending status for running checks#367
NicolasBonet merged 5 commits into
mainfrom
nicolas-checkrun-status-fixes

Conversation

@NicolasBonet

@NicolasBonet NicolasBonet commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

Fixed Issues

$ https://github.com/Expensify/Expensify/issues/668743

Problem

The Github Actions: status shown on PR list items had two issues:

  1. PRs failing only the "Verify peer review" workflow (its Check independent approval job) showed Github Actions: failure. That check fails by design until a peer review happens, so it's noise for the author — not a CI failure to act on.
  2. PRs with checks still running showed Github Actions: success as soon as any single check completed successfully. Check runs only get a conclusion once they complete, so in-progress runs (conclusion: null) were silently skipped by the reducer.

Solution

In the check-run conclusion reducer (src/js/lib/actions/PullRequests.js):

  • Skip check runs listed in a new IGNORED_CHECK_RUN_NAMES constant, currently just Check independent approval, so that check never affects the overall conclusion.
  • Return a new pending conclusion when any check run has status !== 'completed'. Priority is now: failure > pending > success > skipped > unknown. No CSS change needed — non-success/failure statuses already render in the default orange.

Tests

  1. Load the unpacked extension from dist/ after npm run build.
  2. Open a K2 view (e.g. https://github.com/Expensify/Expensify#k2) and find the "Your Pull Requests" section.
  3. Verify a PR whose only failing check is Check independent approval (e.g. a PR failing only the "Verify peer review" workflow) shows Github Actions: success in green.
  4. Push a commit to a PR so its checks re-run, and verify the row shows Github Actions: pending in orange while checks are running.
  5. Verify a PR with a genuinely failing check still shows Github Actions: failure in red.

🤖 Generated with Claude Code

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
NicolasBonet and others added 3 commits August 5, 2026 15:40
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@NicolasBonet
NicolasBonet requested a review from a team August 5, 2026 20:48
@melvin-bot
melvin-bot Bot requested review from Gonals and removed request for a team August 5, 2026 20:49

@roryabraham roryabraham left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we simplify and just ignore this check outright for K2? I'm not sure we need this piece:

A PR with no human reviewer has nobody lined up to review it, so the failure stays visible as a prompt to find one.

Before we added the check, we never had this. So we should basically try to preserve the behavior we had before.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@NicolasBonet

NicolasBonet commented Aug 5, 2026

Copy link
Copy Markdown
Contributor Author

Can we simplify and just ignore this check outright for K2? I'm not sure we need this piece:

A PR with no human reviewer has nobody lined up to review it, so the failure stays visible as a prompt to find one.

Before we added the check, we never had this. So we should basically try to preserve the behavior we had before.

@roryabraham I felt like if this fails and no one is assigned, it's probably an issue on my end as I haven't assigned a reviewer, but we can follow up if we decide to do that.

@NicolasBonet
NicolasBonet requested review from roryabraham and removed request for Gonals August 5, 2026 21:10
@NicolasBonet NicolasBonet reopened this Aug 6, 2026
@NicolasBonet
NicolasBonet merged commit 00b828d into main Aug 6, 2026
9 of 10 checks passed
@NicolasBonet
NicolasBonet deleted the nicolas-checkrun-status-fixes branch August 6, 2026 02:49
@os-botify

os-botify Bot commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

🚀 Released in version 1.5.51 🚀

@melvin-bot

melvin-bot Bot commented Aug 6, 2026

Copy link
Copy Markdown

@NicolasBonet looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

@melvin-bot melvin-bot Bot added the Emergency label Aug 6, 2026
@NicolasBonet

Copy link
Copy Markdown
Contributor Author

This missed @roryabraham:

CleanShot 2026-08-05 at 22 16 48@2x

Approver:

CleanShot 2026-08-05 at 22 17 18@2x

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants