Ignore peer review check and show pending status for running checks - #367
Conversation
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
roryabraham
left a comment
There was a problem hiding this comment.
Can we simplify and just ignore this check outright for K2? I'm not sure we need this piece:
A PR with no human reviewer has nobody lined up to review it, so the failure stays visible as a prompt to find one.
Before we added the check, we never had this. So we should basically try to preserve the behavior we had before.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@roryabraham I felt like if this fails and no one is assigned, it's probably an issue on my end as I haven't assigned a reviewer, but we can follow up if we decide to do that. |
|
🚀 Released in version 1.5.51 🚀 |
|
@NicolasBonet looks like this was merged without a test passing. Please add a note explaining why this was done and remove the |
|
This missed @roryabraham:
Approver:
|


Fixed Issues
$ https://github.com/Expensify/Expensify/issues/668743
Problem
The
Github Actions:status shown on PR list items had two issues:Check independent approvaljob) showedGithub Actions: failure. That check fails by design until a peer review happens, so it's noise for the author — not a CI failure to act on.Github Actions: successas soon as any single check completed successfully. Check runs only get aconclusiononce they complete, so in-progress runs (conclusion: null) were silently skipped by the reducer.Solution
In the check-run conclusion reducer (
src/js/lib/actions/PullRequests.js):IGNORED_CHECK_RUN_NAMESconstant, currently justCheck independent approval, so that check never affects the overall conclusion.pendingconclusion when any check run hasstatus !== 'completed'. Priority is now:failure>pending>success>skipped>unknown. No CSS change needed — non-success/failure statuses already render in the default orange.Tests
dist/afternpm run build.Check independent approval(e.g. a PR failing only the "Verify peer review" workflow) showsGithub Actions: successin green.Github Actions: pendingin orange while checks are running.Github Actions: failurein red.🤖 Generated with Claude Code