[TS] Allow deep null values on merge operations#381
Merged
MonilBhavsar merged 1 commit intoExpensify:mainfrom Oct 3, 2023
Merged
[TS] Allow deep null values on merge operations#381MonilBhavsar merged 1 commit intoExpensify:mainfrom
MonilBhavsar merged 1 commit intoExpensify:mainfrom
Conversation
melvin-bot
bot
requested review from
MonilBhavsar
and removed request for
a team
blazejkustra
approved these changes
Oct 2, 2023
Contributor
|
I could not find the reason why it was reverted before and what we have done to prevent that. Could you please share some context |
Contributor
Author
|
@MonilBhavsar This PR was reverted because of this. We took the opportunity of that PR to fix some typings on Onyx related to |
MonilBhavsar
approved these changes
Oct 3, 2023
Contributor
MonilBhavsar
left a comment
MonilBhavsar
left a comment
There was a problem hiding this comment.
Thanks! Looks good to me 👍
57 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details
This PR fix the typings related to
mergeoperations to allow settingnullto deep properties inside the object. Currently this is blocking several TS PRs. They were fixed on this PR but it got reverted, so I created a separate one.cc @blazejkustra
Related Issues
Automated Tests
Linked PRs