Skip to content

chore(deps): bump io.extendreality.zinnia.unity from 1.38.0 to 1.38.1#14

Merged
dependabot[bot] merged 1 commit intomasterfrom
dependabot/npm_and_yarn/io.extendreality.zinnia.unity-1.38.1
Jul 21, 2021
Merged

chore(deps): bump io.extendreality.zinnia.unity from 1.38.0 to 1.38.1#14
dependabot[bot] merged 1 commit intomasterfrom
dependabot/npm_and_yarn/io.extendreality.zinnia.unity-1.38.1

Conversation

@dependabot
Copy link
Copy Markdown
Contributor

@dependabot dependabot Bot commented on behalf of github Jul 21, 2021

Bumps io.extendreality.zinnia.unity from 1.38.0 to 1.38.1.

Release notes

Sourced from io.extendreality.zinnia.unity's releases.

v1.38.1

1.38.1 (2021-07-21)

Bug Fixes

  • Tracking: ensure right trigger exit happens on kinematic change (19c14ce)

    There was an issue with the 2019 kinematic fix where if a GameObject with multiple child colliders was touched on one collider and then when the kinematic state changed the collider would no longer be touched but another collider in the GameObject was touched then the exit event would not happen for the original collider and the new start event for the new collider would not happen.

    This would mean the collision with the original collider would have ended in the CollisionTracker but the CollisionTracker would not have reported it, and the new collider collision would not have a started event reported. Then when the actual new collider collision ended it would not report it had ended correctly.

    The fix is to hold a dictionary for each collider and their frame interaction timestamp and then this is checked in the fix logic for the Exit/Enter that happens when the kinematic state is changed.

    If the collider has changed then it won't cancel the deferred trigger exit so the exit will happen as expected, but if the collider hasn't changed then the deferred exit will be cancelled in the enter to prevent the enter/exit issue.

    A new test has been added to prove all this logic works.

Changelog

Sourced from io.extendreality.zinnia.unity's changelog.

1.38.1 (2021-07-21)

Bug Fixes

  • Tracking: ensure right trigger exit happens on kinematic change (19c14ce)

    There was an issue with the 2019 kinematic fix where if a GameObject with multiple child colliders was touched on one collider and then when the kinematic state changed the collider would no longer be touched but another collider in the GameObject was touched then the exit event would not happen for the original collider and the new start event for the new collider would not happen.

    This would mean the collision with the original collider would have ended in the CollisionTracker but the CollisionTracker would not have reported it, and the new collider collision would not have a started event reported. Then when the actual new collider collision ended it would not report it had ended correctly.

    The fix is to hold a dictionary for each collider and their frame interaction timestamp and then this is checked in the fix logic for the Exit/Enter that happens when the kinematic state is changed.

    If the collider has changed then it won't cancel the deferred trigger exit so the exit will happen as expected, but if the collider hasn't changed then the deferred exit will be cancelled in the enter to prevent the enter/exit issue.

    A new test has been added to prove all this logic works.

Commits
  • 9f66c5b chore(release): set version to 1.38.1 [skip ci]
  • e251669 Merge pull request #548 from ExtendRealityLtd/fix/collision-tracker-2019-logic
  • 19c14ce fix(Tracking): ensure right trigger exit happens on kinematic change
  • See full diff in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [io.extendreality.zinnia.unity](https://github.com/ExtendRealityLtd/Zinnia.Unity) from 1.38.0 to 1.38.1.
- [Release notes](https://github.com/ExtendRealityLtd/Zinnia.Unity/releases)
- [Changelog](https://github.com/ExtendRealityLtd/Zinnia.Unity/blob/master/CHANGELOG.md)
- [Commits](ExtendRealityLtd/Zinnia.Unity@v1.38.0...v1.38.1)

---
updated-dependencies:
- dependency-name: io.extendreality.zinnia.unity
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot Bot added the dependency-update A change that only updates a dependency label Jul 21, 2021
@dependabot dependabot Bot requested a review from thestonefox July 21, 2021 12:16
Copy link
Copy Markdown
Member

@thestonefox thestonefox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dependabot merge

@dependabot dependabot Bot merged commit 245d8ec into master Jul 21, 2021
@dependabot dependabot Bot deleted the dependabot/npm_and_yarn/io.extendreality.zinnia.unity-1.38.1 branch July 21, 2021 12:32
@ExtendReality-Bot
Copy link
Copy Markdown
Member

🎉 This PR is included in version 1.1.8 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependency-update A change that only updates a dependency released

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants