fix: stop idempotent job insert storms - #3059
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
varchar(255)schema so oversized batch titles remain insertableProduction mechanism
Read-only Events diagnostics found one durable worklist item retried continuously with a 295-character title. Calling WordPress's
wpdb::process_fields()against the live jobs schema returnedfalsespecifically for that label before SQL execution. The recovery lookup then resetwpdb->last_error, so every failure was logged with an empty database error and the worklist returned the item toreadyfor another attempt.The existing unique
idx_idempotency_keyindex is present and healthy; Action Scheduler retention pressure remains separately tracked in #2792 and #2793.Verification
php tests/jobs-idempotent-insert-recovery-smoke.php(21 assertions)php tests/prefix-policy-audit.php(11 passed)git diff --checkHomeboy's selected WP smoke wrapper could not launch because the host WP Codebox cache is missing
packages/cli/dist/index.js; the selected standalone test passes directly.Closes #3058