fix: defer fetch acknowledgement until packet disposition - #3208
Merged
Conversation
This was referenced Aug 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Production Reproduction
Phoenix venue flow
858extracted 52 fresh source packets. AI emitted 27 packets, upsert received 27, and the job completed with no errors. An immediate rerun returned no items because all 52 identifiers had been acknowledged before downstream disposition.Verification
git diff --checkpassedTest Infrastructure
A real two-connection MySQL lock-order test is included in
ItemClaimLifecycleTest. Local execution is blocked because/tmp/wordpress-tests-lib/wp-tests-config.phpis not configured; tracked separately in #3207. Deterministic production-class transaction tests cover rollback, deadlock retry, cache ordering, recovery takeover, and exact claim outcomes locally.Compatibility And Safety
Fixes #3206
AI assistance: Used for production diagnosis, iterative implementation, adversarial concurrency review, fault-injection test design, and final verification. Multiple unsafe intermediate candidates were rejected before this version reached a clean independent review.