Merged
Conversation
Collaborator
|
This will need changes in the lobby server. Even for token login the lobby server still seems to be checking the database for steamid. |
Member
Author
|
I thought the lobby server was checking steamid anymore for tokens? That was all on the user service. Because didnt we have that issue where for a short while the tokens could be used to log in without linking. |
Collaborator
|
I guess it doesn't enforce steam linking but it uses the presence of a steam id to determine if it can ignore the policy server result. If it can't find steam ids then people might get blocked from logging in by the policy server. |
Member
Author
|
ah gotcha, but regardless this change would just have that db call be on a separate table they are still linked by user id |
Brutus5000
requested changes
Jan 3, 2022
Brutus5000
reviewed
Jan 3, 2022
Brutus5000
reviewed
Jan 3, 2022
Brutus5000
reviewed
Jan 3, 2022
Brutus5000
reviewed
Jan 4, 2022
Brutus5000
reviewed
Jan 6, 2022
Brutus5000
reviewed
Jan 16, 2022
Brutus5000
reviewed
Feb 12, 2022
Sheikah45
force-pushed
the
feature/service-links-table
branch
from
55276c4 to
91a9a2d
Compare
Sheikah45
force-pushed
the
feature/service-links-table
branch
from
458343e to
0e1be80
Compare
Brutus5000
approved these changes
Jul 18, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.