Skip to content

Add population of the service links table#536

Merged
Sheikah45 merged 1 commit intodevelopfrom
feature/populate_links_table
Jul 23, 2022
Merged

Add population of the service links table#536
Sheikah45 merged 1 commit intodevelopfrom
feature/populate_links_table

Conversation

@Sheikah45
Copy link
Member

@Brutus5000 let me know if this is how you thought of it.

Dependent on FAForever/db#294

@codecov
Copy link

codecov bot commented Jul 18, 2022

Codecov Report

Merging #536 (a60a737) into develop (b50b71c) will increase coverage by 0.17%.
The diff coverage is 84.61%.

❗ Current head a60a737 differs from pull request most recent head 425dd6c. Consider uploading reports for the commit 425dd6c to get more accurate results

@@              Coverage Diff              @@
##             develop     #536      +/-   ##
=============================================
+ Coverage      75.46%   75.63%   +0.17%     
- Complexity      1144     1155      +11     
=============================================
  Files            242      244       +2     
  Lines           3639     3674      +35     
  Branches         231      232       +1     
=============================================
+ Hits            2746     2779      +33     
- Misses           796      798       +2     
  Partials          97       97              
Impacted Files Coverage Δ
.../main/java/com/faforever/api/user/UserService.java 90.79% <78.37%> (-0.37%) ⬇️
...ava/com/faforever/api/data/domain/AccountLink.java 100.00% <100.00%> (ø)
...m/faforever/api/data/domain/LinkedServiceType.java 100.00% <100.00%> (ø)
...main/java/com/faforever/api/data/domain/Login.java 85.00% <100.00%> (-0.72%) ⬇️
...n/java/com/faforever/api/voting/VotingService.java 89.09% <100.00%> (+1.81%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b50b71c...425dd6c. Read the comment docs.

Brutus5000
Brutus5000 previously approved these changes Jul 18, 2022
Use the service links for checks and remove steam id and gog id from player
Copy link
Member

@Brutus5000 Brutus5000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should not yet remove steamid from the entity and rather mark it as deprecated (and/or populate it with value deprecated) in order to avoid breaking compatibility with other apps (moderator client)

@Sheikah45
Copy link
Member Author

Do you mean just for visibility sake?
Because it wouldn't break the mod client the Id would just be null in the user management view

@Sheikah45 Sheikah45 merged commit 86b87fc into develop Jul 23, 2022
@Sheikah45 Sheikah45 deleted the feature/populate_links_table branch July 23, 2022 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants