Skip to content

Revert czar AA angle limit buff - #7172

Merged
Rhaelya merged 11 commits into
developfrom
balance/czar-angles-and-cost
Jul 12, 2026
Merged

Revert czar AA angle limit buff#7172
Rhaelya merged 11 commits into
developfrom
balance/czar-angles-and-cost

Conversation

@lL1l1

@lL1l1 lL1l1 commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

Description of the proposed changes

Reverts the angle limit change in #7152 as the czar performs fine against air and is only problematic against spread out surface AA.

Checklist

- [ ] Changes are annotated, including comments where useful

Summary by CodeRabbit

  • Balance
    • Updated the CZAR Experimental Aircraft Carrier’s costs and build time.
    • Improved anti-air weapon targeting behavior by tightening firing arcs and adjusting per-weapon heading constraints, improving consistency of defensive coverage.
  • Documentation
    • Refreshed formatting for balance-related changelog entries to ensure unit names/titles display consistently.

@lL1l1
lL1l1 requested a review from Rhaelya July 8, 2026 04:09
@lL1l1 lL1l1 added the area: balance idea related to suggestions for unit balance label Jul 8, 2026
@coderabbitai

coderabbitai Bot commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 6468891b-bbef-479f-b85d-e4474ff920cc

📥 Commits

Reviewing files that changed from the base of the PR and between 8cccce0 and 5fdcd3f.

📒 Files selected for processing (1)
  • changelog/snippets/category.7158.md
💤 Files with no reviewable changes (1)
  • changelog/snippets/category.7158.md

📝 Walkthrough

Walkthrough

This PR updates CZAR’s SonicPulseBattery weapon settings to use explicit heading arc limits on all four batteries and revises the matching balance changelog snippet.

Changes

CZAR AA Battery Firing Constraints

Layer / File(s) Summary
Restore heading arc limits on SonicPulse batteries
units/UAA0310/UAA0310_unit.bp
FiringTolerance is reduced to 45 and HeadingArcCenter/HeadingArcRange = 120 are added for Battery1–Battery4, each with a distinct HeadingArcCenter value.
Update balance changelog snippet
changelog/snippets/balance.7152.md
Snippet reformatted with a {% unit UAA0310 %} wrapper, retaining cost/build-time reductions and removing the prior note on removed AA missile firing-angle limits.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related PRs

  • FAForever/fa#7152: Touches the same CZAR SonicPulseBattery weapon settings and the same balance snippet, with related heading-arc and firing-tolerance changes.
  • FAForever/fa#7086: Related to the {% unit ... %} changelog snippet format used here.

Suggested labels: area: changelog management

Suggested reviewers: Rhaelya

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly matches the main change: reverting the czar AA angle-limit buff.
Description check ✅ Passed The description covers the change and checklist, but omits the Testing done and Additional context sections.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch balance/czar-angles-and-cost

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@lL1l1
lL1l1 force-pushed the balance/czar-angles-and-cost branch from 3ac6e56 to 8cccce0 Compare July 8, 2026 04:12
@lL1l1
lL1l1 marked this pull request as ready for review July 8, 2026 04:12

@Rhaelya Rhaelya left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@Rhaelya
Rhaelya merged commit 344ae69 into develop Jul 12, 2026
5 checks passed
@Rhaelya
Rhaelya deleted the balance/czar-angles-and-cost branch July 12, 2026 16:05
@github-project-automation github-project-automation Bot moved this from To Discuss to Done in 2025 - Balance Iteration I Jul 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: balance idea related to suggestions for unit balance

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants