Skip to content

Update rules.md#598

Merged
Brutus5000 merged 1 commit into
FAForever:developfrom
VoRGoR:patch-1
Jul 11, 2026
Merged

Update rules.md#598
Brutus5000 merged 1 commit into
FAForever:developfrom
VoRGoR:patch-1

Conversation

@VoRGoR

@VoRGoR VoRGoR commented Jul 11, 2026

Copy link
Copy Markdown
Member

Update to rules regarding leaving games in the gamemodes "Share Until Death", "Partial Share", and "Union Control".

Summary by CodeRabbit

  • Documentation
    • Updated “Commit to Competition” guidance for leaving games.
    • Added specific instructions for “Share Until Death or Partial Share” and “Union Control” scenarios, including ACU safety and disconnection guidance.

Update to rules regarding leaving games in the gamemodes "Share Until Death", "Partial Share", and "Union Control".
@coderabbitai

coderabbitai Bot commented Jul 11, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: d9b60658-8f7a-487c-a692-c2c7010a8a11

📥 Commits

Reviewing files that changed from the base of the PR and between 4d5701d and 3bb1087.

📒 Files selected for processing (1)
  • src/backend/templates/views/markdown/rules.md

📝 Walkthrough

Walkthrough

Updated “Commit to Competition” guidance under “Leaving games” with separate instructions for Share Until Death or Partial Share and Union Control.

Changes

Competition guidance

Layer / File(s) Summary
Leaving-game instruction cases
src/backend/templates/views/markdown/rules.md
Replaces the former share-until-death guidance with instructions for transferring units before going AFK, avoiding ACU explosion friendly fire, and disconnecting without self-destructing the ACU.

Estimated code review effort: 1 (Trivial) | ~2 minutes

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Title check ❓ Inconclusive The title is related to the changed file, but it is too generic to clearly describe the rules update. Rename it to mention the gameplay rule changes, e.g. "Clarify leaving-game rules for Share Until Death and Union Control".
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@Brutus5000 Brutus5000 merged commit e789940 into FAForever:develop Jul 11, 2026
4 checks passed
@VoRGoR VoRGoR deleted the patch-1 branch July 12, 2026 00:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants