feat: grid-item用icon插槽时也能用info属性#12
Merged
levy9527 merged 4 commits intoFEMessage:devfrom Nov 12, 2019
Merged
Conversation
eviIIt
approved these changes
Nov 12, 2019
lianghx-319
approved these changes
Nov 12, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
原本的grid-item的info属性是直接传给内部的Icon组件的，这意味着你用了icon插槽就没法用dot和info属性了！
How
在grid-item内：
另外，现在pre-push时会执行yarn test
Test
yarn lint
yarn test
yarn test src/grid