feat(search): enhance search input for iOS #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for femessage-vant ready! Built with commit 04294c2 |
lianghx-319
force-pushed
the
feat/enhance-search-input
branch
from
c902112 to
e003279
Compare
colmugx
approved these changes
Oct 25, 2019
donaldshen
approved these changes
Oct 25, 2019
eviIIt
approved these changes
Oct 25, 2019
colmugx
reviewed
Oct 25, 2019
| ); | ||
| } | ||
|
|
||
| if (props.removeForm) { |
Member
There was a problem hiding this comment.
不需要 withForm
甚至可以不需要配置，直接套上 form
levy9527
approved these changes
Oct 29, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
With iOS, it will apply developer nest this component in a
formtag to get 「search」return button in keyboard. This enhancement lets us implement it call the component without extra next HTML element.How
Show in the pr code review.
Test
Before
run
yarn testruntime case
After
run
yarn testruntime case
