REcoM as a submodule in FESOM#911
Conversation
4541a9c to
8a4deda
Compare
|
Nice! Differences seem to be numerical in nature. There is a script to update the truth values in https://github.com/FESOM/fesom2/blob/recom_submodule_update/setups/update_truth_values.sh |
| @@ -0,0 +1,3 @@ | |||
| [submodule "src/recom"] | |||
| path = src/recom | |||
| url = https://github.com/RECOM-Regulated-Ecosystem-Model/REcoM_Standalone | |||
|
Hello, the differences are due to the compilation flags which are not the same in the REcoM standalone. I've updated that in the latest version of REcoM and will update it soon here also. |
If you think you can recover bit-identicalness, all the better. |
|
@ogurses I have updated the url. We talked about another commit of yours which was in @JanStreffing The bit-identicalness has been restored for the CI tests. The differences were, as I mentioned, due to different compilation flags. I have fixed that, but note that on the new CMakeLists.txt of REcoM these options are added just for when the build is happening inside of the CI. When running on any other system I think it will inherit the default compilation flags set by FESOM. |
REcoM as a submodule in FESOM
This is a new updated version of the work for having REcoM as a submodule in FESOM.
It uses the most updated version of REcoM in https://github.com/RECOM-Regulated-Ecosystem-Model/REcoM and will separate the concerns and developments of both models.
It will also be very valuable to facilitate rework and refactoring which are now taking place in an active natESM sprint.