Skip to content

REcoM as a submodule in FESOM#911

Merged
JanStreffing merged 6 commits into
mainfrom
recom_submodule_update
May 12, 2026
Merged

REcoM as a submodule in FESOM#911
JanStreffing merged 6 commits into
mainfrom
recom_submodule_update

Conversation

@wiltonloch

Copy link
Copy Markdown
Collaborator

This is a new updated version of the work for having REcoM as a submodule in FESOM.

It uses the most updated version of REcoM in https://github.com/RECOM-Regulated-Ecosystem-Model/REcoM and will separate the concerns and developments of both models.

It will also be very valuable to facilitate rework and refactoring which are now taking place in an active natESM sprint.

@wiltonloch
wiltonloch force-pushed the recom_submodule_update branch from 4541a9c to 8a4deda Compare May 11, 2026 10:20
@JanStreffing

Copy link
Copy Markdown
Collaborator

Nice! Differences seem to be numerical in nature. There is a script to update the truth values in https://github.com/FESOM/fesom2/blob/recom_submodule_update/setups/update_truth_values.sh

Comment thread .gitmodules Outdated
@@ -0,0 +1,3 @@
[submodule "src/recom"]
path = src/recom
url = https://github.com/RECOM-Regulated-Ecosystem-Model/REcoM_Standalone

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check the URL!!

@wiltonloch

Copy link
Copy Markdown
Collaborator Author

Hello, the differences are due to the compilation flags which are not the same in the REcoM standalone. I've updated that in the latest version of REcoM and will update it soon here also.

@JanStreffing

Copy link
Copy Markdown
Collaborator

Hello, the differences are due to the compilation flags which are not the same in the REcoM standalone. I've updated that in the latest version of REcoM and will update it soon here also.

If you think you can recover bit-identicalness, all the better.

@wiltonloch

Copy link
Copy Markdown
Collaborator Author

@ogurses I have updated the url. We talked about another commit of yours which was in recom_submodule that updated the config files, but apparently the changes there are already in the main branch of FESOM. As there were no differences between the tip of this branch and that commit for the config files.

@JanStreffing The bit-identicalness has been restored for the CI tests. The differences were, as I mentioned, due to different compilation flags. I have fixed that, but note that on the new CMakeLists.txt of REcoM these options are added just for when the build is happening inside of the CI. When running on any other system I think it will inherit the default compilation flags set by FESOM.

@wiltonloch
wiltonloch marked this pull request as ready for review May 12, 2026 13:57
@JanStreffing
JanStreffing merged commit 10acf1a into main May 12, 2026
20 checks passed
@JanStreffing
JanStreffing deleted the recom_submodule_update branch May 12, 2026 14:02
patrickscholz pushed a commit that referenced this pull request Jun 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants