Expose set original cell index to python - #3504
Merged
Merged
Conversation
Member
|
Mixed topology support is still highly experimental and under review, so we shouldn’t expose the mixed topology version of original_cell_index yet. When it’s ready, no need to add a function with ‘set’ in the name. Could be a nanobind read/write property. |
Member
Author
agreed, much cleaner solution 👍🏻 |
schnellerhase
pushed a commit
to schnellerhase/fenics-dolfinx
that referenced
this pull request
Dec 28, 2024
* Expose set original cell index to python * Create read-write property
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To be able to make a valid geometry from Python (without using create_topology, as one wants to avoid re-distribution of data), one has to expose the
original_cell_indexattribute to Python.As we have used this as a public variable in C++, I've gone down the route of creating a setter function in the Python binding, rather than exposing a "list-of-lists" to Python, as we would rather like it to be numpy based.