Simplify input to non-linear problem - #3751
Merged
Merged
Conversation
…ermine what the vector kind should be. use interface to solve Cahn-Hilliard problem
jhale
reviewed
Jun 16, 2025
jhale
reviewed
Jun 16, 2025
Member
|
Looks good - two small comments then it can be merged. |
jhale
approved these changes
Jun 16, 2025
Member
Author
Added a reply wrt to convergence checks. Do you want this specified in the demo, or is it sufficient that PETSc documents it? |
jorgensd
enabled auto-merge
June 16, 2025 09:37
ordinary-slim
pushed a commit
to ordinary-slim/dolfinx
that referenced
this pull request
Jul 6, 2025
* Simplify kind input to non-linear problem. The matrix kind should determine what the vector kind should be. use interface to solve Cahn-Hilliard problem * Remove features we do not show any more * Simplify fallback * Document incremental convergence.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The matrix kind should determine what the vector kind should be.
The naming of inputs are now consistent with
dolfinx.fem.petsc.LinearProblem(#3684)Use interface to solve Cahn-Hilliard problem (resolves #3749)