Check PETSc options prefix is not empty - #3796
Merged
schnellerhase merged 2 commits intoJul 11, 2025
Merged
Conversation
schnellerhase
marked this pull request as ready for review
July 11, 2025 12:40
schnellerhase
changed the title
Member
|
Every meaningful options prefix will also end with |
francesco-ballarin
approved these changes
Jul 11, 2025
Co-authored-by: Chris Richardson <chris@bpi.cam.ac.uk>
chrisrichardson
self-requested a review
July 11, 2025 13:39
chrisrichardson
approved these changes
Jul 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up to #3785.
Passing an empty
petsc_options_prefixstring breaks. This is composed of PETSc's optional type handling ofgetOptionsPrefixand input ofsetOptionsPrefixnot aligning, and the internal empty c-string being encoded as "\0" instead of "".As an empty prefix is not desirable, we just raise to avoid this.
Debugged with @jhale.