You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Caused by default scalar type being complex in the ufl dolfinx integration test. In this case form, function and coefficients are constructed from default type (complex), but the boundary condition from a float value. This caused a mismatch.
So, changing from extracting the dtype from the value passed to dirichletbc, to instead extracting it from the function space (on which we want to apply it) and casting the value (array) to its dtype?
So, changing from extracting the dtype from the value passed to dirichletbc, to instead extracting it from the function space (on which we want to apply it) and casting the value (array) to its dtype?
The function space doesn’t know the dtype? It is only the function we are applying it to that knows the dtype.
Ah right, function space only knows the geometry dtype. Then I don't know what to change it to.
I'd suggest (i) moving bc closer to where it's used, and (ii) getting the dtype from the Form it acts on. default_scalar_type is something a bit ugly we need to live with but should use as little as possible.
Ah right, function space only knows the geometry dtype. Then I don't know what to change it to.
I'd suggest (i) moving bc closer to where it's used, and (ii) getting the dtype from the Form it acts on. default_scalar_type is something a bit ugly we need to live with but should use as little as possible.
That has to be slightly adapted to work with bc.set:
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes FEniCS/ufl#399.
Caused by default scalar type being complex in the ufl dolfinx integration test. In this case form, function and coefficients are constructed from default type (complex), but the boundary condition from a float value. This caused a mismatch.
Tested at https://github.com/FEniCS/ufl/actions/runs/16607427384/job/46982707793