Provide commit SHA for Spack install - #3913
Merged
Merged
Conversation
garth-wells
marked this pull request as ready for review
September 12, 2025 10:43
garth-wells
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using
spack developto point Spack to source code, Spack cannot guarantee 'binary provenance' and associate a git hash. This can cause caching problems because a build doesn't have an associated hash.This change set the DOLFINx commit hash via the
commitvariant.This change doesn't extend to the dependent packages (Basix, FFCx, UFL). We could easily fix this if we insist on Basix, FFCx, UFL from branches on the main repo.