Skip to content

fix: short-syntax env_file is optional, not required - #77

Merged
FIERsity merged 1 commit into
mainfrom
fix/env-file-missing-optional
Aug 6, 2026
Merged

fix: short-syntax env_file is optional, not required#77
FIERsity merged 1 commit into
mainfrom
fix/env-file-missing-optional

Conversation

@FIERsity

@FIERsity FIERsity commented Aug 6, 2026

Copy link
Copy Markdown
Owner

Bug

String-form env_file: was normalized to required: true, so a missing env file — the gitignored .env in a fresh clone, or mastodon .env.production — produced a hard I/O error. docker compose config treats it as a notice and exits 0 (verified against Docker).

Fix

  • Short-syntax env_file → optional; missing files are skipped with info [env-file-missing]
  • ServiceReport.diagnostics added (JSON additive) and surfaced through the audit
  • Long syntax {path, required: true} still errors as before

Verification

  • New integration test (missing env_file → audit success + env-file-missing)
  • mastodon real compose: hard error → clean audit with 3 info notices
  • 136 tests green, clippy -D warnings clean

A string-form env_file (the overwhelmingly common case) was marked
required: true, so any project whose env file is missing — a gitignored
.env in a fresh clone, mastodon .env.production — hard-errored with an
I/O error. docker compose config exits 0 with a "not found" notice;
the analyzer now mirrors that: missing short-syntax env files are
skipped and reported as info [env-file-missing] (surfaced via new
ServiceReport.diagnostics through the audit). Long syntax with
required: true still errors.

Verified against Docker on the real mastodon compose: both succeed.
136 tests green.
@coderabbitai

coderabbitai Bot commented Aug 6, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@FIERsity, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 32 minutes

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 0337ce50-f8e4-4b1b-89cc-e52727371e7e

📥 Commits

Reviewing files that changed from the base of the PR and between 85e273d and ff0d124.

📒 Files selected for processing (5)
  • src/audit.rs
  • src/compose.rs
  • src/graph.rs
  • src/model.rs
  • tests/cli.rs

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@FIERsity
FIERsity merged commit 744c84b into main Aug 6, 2026
3 checks passed
@FIERsity
FIERsity deleted the fix/env-file-missing-optional branch August 6, 2026 03:54
FIERsity added a commit that referenced this pull request Aug 6, 2026
The short-syntax env_file optionality fix (mastodon-class hard errors on
gitignored .env files) shipped without a changelog entry; added to the
1.12.0 Fixed section.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant