Pin plugins v1.6.20 - #1482
Merged
Merged
Conversation
Carries fog-plugins #31, which applies the three relationships fogproject #1481 declared: capone.cImageID and capone.cOSID RESTRICT to `images` and `os`, subnetgroup.sgGroupID CASCADE to `groups`. Without the bump those steps exist in the repository and reach no server -- fetch-plugins.sh resolves the pin, not main. Also carries the gate that should have demanded them. tests/foreign-key-map.test.php walks commons/schema-expected.php, which is 70 core tables, so a plugin's id columns were never asked about; the matching gate has to live in the plugin repo because that one is fetched on its own and is the only side that knows its own tables. Verified by running bin/fetch-plugins.sh against the new pin: v1.6.20 downloads, its sha256 verifies, and the unpacked capone manager carries the step. Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Carries fog-plugins #31 / v1.6.20, which applies the three relationships #1481 declared.
Without this bump those steps exist in the repository and reach no server:
bin/fetch-plugins.shresolvesFOG_PLUGINS_VERSION, notmain.capone.cImageIDimages.imageIDcapone.cOSIDos.osIDsubnetgroup.sgGroupIDgroups.groupIDThe release also carries
tests/plugin-id-columns-are-classified.test.php, the half of the classification gate that has to live in the plugin repo — core's gate walkscommons/schema-expected.php, which is 70 core tables, so a plugin's id columns were never asked about.Verified by running the real thing, not by inspection:
bin/fetch-plugins.shagainst the new pin downloads v1.6.20, verifies its sha256, unpacks 17 plugins, and the resultingcaponemanager.class.phpcarriesapplyConstraints('capone').