Added additional auxiliarly methods for detecting interface IP and ge… - #79
Closed
wayneworkman wants to merge 1 commit into
Closed
Added additional auxiliarly methods for detecting interface IP and ge…#79wayneworkman wants to merge 1 commit into
wayneworkman wants to merge 1 commit into
Conversation
…tting subnet mask of that interface should they not be already set - to fix the DHCP configuration file.
mastacontrola
added a commit
that referenced
this pull request
Sep 5, 2026
Reported against host 105: the summary says 79 events, expanding shows 10, and there is no pager and no scroll to reach the other 69. Self-inflicted. The child table was written as a bare .DataTable(), which opts out of every convention registerTable() applies -- including its `dom`, which is where the pager lives, and its Scroller setup. It went through the helper's defaults for nothing and got DataTables' instead. Building it with registerTable() fixes the report and answers the wider question at the same time: the child now carries the SAME infinite scroll as every other grid in FOG. Collapsed grouping and infinite scroll were never actually in tension -- the tension is between rowGroup and Scroller, and grouping in SQL means there is no rowGroup to have it with. Nothing about registerTable() needed changing to get both. Reproduced and verified in a standalone harness driving the real fog.common.js and DataTables against a stubbed endpoint, because the UI itself is behind an identity provider I cannot sign in to. Before: 10 rows loaded of 79, Scroller off, no scroll body. After: 79 of 79, Scroller on, a 560px viewport over 1742px of content, scrolled to the bottom, last row "event #79". That harness also surfaced an uncaught TypeError from fog.common.js itself. registerTable() sizes a Scroller table on a setTimeout(0) after init, and a grid built into a node still being attached -- a DataTables child row is exactly that -- reaches fogSizeScroller() before its wrapper is in the document. container() is null there, `outer` falls back to it, and getBoundingClientRect() threw out of the timeout. Now guarded, for the same reason and in the same way the function already guards init(): there is nothing to measure against yet, and whatever attaches the node re-runs the sizing pass once it has. The error is gone from the harness console and the sizing is unchanged. Three mutants killed: the bare .DataTable(), and the null-container guard. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Ft1sYpi27EW7g798fkkWR7
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I added additional auxiliary code for detecting an IP address for a given interface name, and auxiliary code for getting the subnet mask. This is to hopefully fix the IP/Subnet mask detection issues described here: https://forums.fogproject.org/topic/6551/fog-compatibility-test-failed